LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html - Issue 57493002: Remove 'alphabetic' value from text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js ('K') | « LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/style.css ('k') | LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt » ('j') | Source/core/css/CSSParser-in.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html b/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

index 24160c75f73522e737f6b20a4aac93e3a4c3db6f..186889676a23274a8b71f213cf58e6e37069cff2 100644

--- a/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

+++ b/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

@@ -8,14 +8,9 @@

</head>

<body>

- <p>Test if each value (auto, alphabetic and under) works. Auto defaults to

- alphabetic, so they should look the same, that is, the horizontal line

- should cross the 'p' letter in the word 'ipsum'. Under should not cross the

- 'p' letter. Bugzilla link: http://webkit.org/b/102795.</p>

Julien - ping for review 2013/11/04 16:06:43 Let's keep the bugzilla link as it still gives som

abinader 2013/11/04 16:38:02 Ack!

+ <p>Test if each value (auto and under) works. Auto means the horizontal line should cross the 'p' letter in the word 'ipsum'. Under should not cross the 'p' letter.</p>

<div class="auto">auto lorem ipsum</div>

- <div class="alphabetic">alphabetic lorem ipsum</div>

<div class="under">under lorem ipsum</div>

- <div class="auto">auto lorem ipsum <span class="under">under lorem ipsum</span> <span class="alphabetic">alphabetic lorem ipsum</span></div>

+ <div class="auto">auto lorem ipsum <span class="under">under lorem ipsum</span></div>

</body>

</html>