Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 574913002: Revert of Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (patchset #2 id:70001 of https://codereview.chromium.org/574773002/) Reason for revert: The RenderText change needs to be reverted because it causes failure of some chromium browsertest. Original issue's description: > Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (patchset #3 id:60001 of https://codereview.chromium.org/499493003/) > > Reason for revert: > We have fixed the RenderText invalidation issue (crbug.com/394133). > > Original issue's description: > > Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer > > > > setShouldDoFullPaintInvalidation doesn't work for RenderText yet. > > > > BUG=405501 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877 > > TBR=jchaffraix@chromium.org,esprehn@chromium.org,leviw@chromium.org > BUG=405501 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182089 TBR=jchaffraix@chromium.org,esprehn@chromium.org,leviw@chromium.org NOTREECHECKS=true NOTRY=true BUG=405501 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M Source/core/dom/DocumentMarkerController.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Xianzhu
Created Revert of Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer
6 years, 3 months ago (2014-09-17 00:38:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574913002/1
6 years, 3 months ago (2014-09-17 00:40:01 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:40:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182126

Powered by Google App Engine
This is Rietveld 408576698