Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer

Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer

setShouldDoFullPaintInvalidation doesn't work for RenderText yet.

BUG=405501
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877

[Julien - ping for review, 2014-08-22 18:53:09]

This is a terrible bug and we don't want to ship that to our users. Everybody
agrees this is not the right fix but we are short on invalidation reviewers next
week (when dev is cut). Also it's better not to revert the original change for a
single regression so lgtm under several assumptions:
- You fully investigate the bug and land the other patch instead if you get it
on time for the dev cut.
- If another regression pops up, we should revert the original change, not land
this patch.

https://codereview.chromium.org/499493003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/499493003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.h:1098: void
invalidatePaintForWholeRenderer() const;
I think we should not expose invalidatePaintForWholeRenderer but a wrapper
around it that clearly states that YOU SHOULD NOT USE IT (like
doNotUseInvalidatePaintForWholeRendererSynchronously).

[Xianzhu, 2014-08-22 19:11:21]

https://codereview.chromium.org/499493003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/499493003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.h:1098: void
invalidatePaintForWholeRenderer() const;
On 2014/08/22 18:53:09, Julien Chaffraix - PST wrote:
> I think we should not expose invalidatePaintForWholeRenderer but a wrapper
> around it that clearly states that YOU SHOULD NOT USE IT (like
> doNotUseInvalidatePaintForWholeRendererSynchronously).

Done.

[Xianzhu, 2014-08-25 22:39:12]

On 2014/08/22 18:53:09, Julien Chaffraix - PST wrote:
> This is a terrible bug and we don't want to ship that to our users. Everybody
> agrees this is not the right fix but we are short on invalidation reviewers
next
> week (when dev is cut). Also it's better not to revert the original change for
a
> single regression so lgtm under several assumptions:
> - You fully investigate the bug and land the other patch instead if you get it
> on time for the dev cut.

I'm going to land this CL.

As you know, the root reason is about RenderText invalidation. I'm trying let
invalidateTreeIfNeeded also handle RenderText, but it needs more time.

> - If another regression pops up, we should revert the original change, not
land
> this patch.

No new regressions till now :)

[Xianzhu, 2014-08-25 22:39:16]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-25 22:40:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/499493003/40001

[Xianzhu, 2014-08-25 22:46:25]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-25 22:46:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/499493003/60001

[commit-bot: I haz the power, 2014-08-26 01:23:02]

Committed patchset #3 (60001) as 180877

[Xianzhu, 2014-09-16 17:29:31]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/574773002/ by wangxianzhu@chromium.org.

The reason for reverting is: We have fixed the RenderText invalidation issue
(crbug.com/394133)..