Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 574773002: Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (patchset #3 id:60001 of https://codereview.chromium.org/499493003/) Reason for revert: We have fixed the RenderText invalidation issue (crbug.com/394133). Original issue's description: > Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer > > setShouldDoFullPaintInvalidation doesn't work for RenderText yet. > > BUG=405501 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877 TBR=jchaffraix@chromium.org,esprehn@chromium.org,leviw@chromium.org BUG=405501 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182089 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182181

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M Source/core/dom/DocumentMarkerController.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Xianzhu
Created Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer
6 years, 3 months ago (2014-09-16 17:29:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574773002/1
6 years, 3 months ago (2014-09-16 17:30:28 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderObject.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-16 17:30:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574773002/70001
6 years, 3 months ago (2014-09-16 17:38:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574773002/70001
6 years, 3 months ago (2014-09-16 17:47:40 UTC) #11
Julien - ping for review
Awesome, enthusiastic lgtm!!
6 years, 3 months ago (2014-09-16 18:25:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:70001) as 182089
6 years, 3 months ago (2014-09-16 19:11:56 UTC) #13
Xianzhu
A revert of this CL (patchset #2 id:70001) has been created in https://codereview.chromium.org/574913002/ by wangxianzhu@chromium.org. ...
6 years, 3 months ago (2014-09-17 00:38:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574773002/70001
6 years, 3 months ago (2014-09-17 19:09:52 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 19:10:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as 182181

Powered by Google App Engine
This is Rietveld 408576698