Fix media layout tests that made invalid assumptions about timeupdate.

Fix media layout tests that made invalid assumptions about timeupdate.

Blink r182039 removed unnecessary checks against firing timeupdate
events in response to ece894570c5f32f7f404f4c8da9ff8b9f03b75cd, which
made it possible for the currentTime value to remain the same for
brief periods of time.

The media controller tests were accidentally relying on the timeupdate
event that gets automatically fired when MediaController issues a seek.
Instead, we should wait for that seek to complete before issuing play()
and waiting for the timeupdate event that follows.

The audio-concurrent-supported.html test picked a magic number of
timeupdate events (two, to be exact) before inspecting whether
currentTime increased past zero. Again, because we now fire non-periodic
timeupdate events reliably, this test is picking up on the wrong events
to make it's judgement on what currentTime should be.

BUG=414649
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182122

[scherkus (not reviewing), 2014-09-16 21:32:21]

scherkus@chromium.org changed reviewers:
+ acolwell@chromium.org

[scherkus (not reviewing), 2014-09-16 21:32:53]

acolwell: mind sanity checking things here?

[acolwell GONE FROM CHROMIUM, 2014-09-16 21:46:13]

lgtm

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
File LayoutTests/media/media-controller-effective-playback-rate.html (right):

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
LayoutTests/media/media-controller-effective-playback-rate.html:29: // Wait for
bringing up to speed step to complete.
nit: perhaps mention that "bringing up to speed" initiates a seek on the media
element so this is a little more obvious w/o looking at the spec.

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
File LayoutTests/media/media-controller-playbackrate.html (right):

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
LayoutTests/media/media-controller-playbackrate.html:30: // Wait for bringing up
to speed step to complete.
ditto.

[scherkus (not reviewing), 2014-09-16 22:13:31]

thanks!

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
File LayoutTests/media/media-controller-effective-playback-rate.html (right):

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
LayoutTests/media/media-controller-effective-playback-rate.html:29: // Wait for
bringing up to speed step to complete.
On 2014/09/16 21:46:13, acolwell_leaving_chromium_9-23 wrote:
> nit: perhaps mention that "bringing up to speed" initiates a seek on the media
> element so this is a little more obvious w/o looking at the spec.

Done.

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
File LayoutTests/media/media-controller-playbackrate.html (right):

https://codereview.chromium.org/574883002/diff/1/LayoutTests/media/media-cont...
LayoutTests/media/media-controller-playbackrate.html:30: // Wait for bringing up
to speed step to complete.
On 2014/09/16 21:46:13, acolwell_leaving_chromium_9-23 wrote:
> ditto. 

Done.

[scherkus (not reviewing), 2014-09-16 22:14:05]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-09-16 22:14:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/574883002/20001

[commit-bot: I haz the power, 2014-09-16 23:34:01]

Committed patchset #2 (id:20001) as 182122

[philipj_slow, 2014-09-23 11:14:03]

scherkus@, should any of these changes be reverted now? At least
media/audio-concurrent-supported.html looks like it could be simplified.

[scherkus (not reviewing), 2014-09-23 18:26:44]

On 2014/09/23 11:14:03, philipj wrote:
> scherkus@, should any of these changes be reverted now? At least
> media/audio-concurrent-supported.html looks like it could be simplified.

agreed -- https://codereview.chromium.org/600513002/