Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: LayoutTests/media/audio-concurrent-supported.html

Issue 574883002: Fix media layout tests that made invalid assumptions about timeupdate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase + fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/media/audio-concurrent-supported-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/media/audio-concurrent-supported.html
diff --git a/LayoutTests/media/audio-concurrent-supported.html b/LayoutTests/media/audio-concurrent-supported.html
index 07d540a135e7e90cec34541fa604adddbc53421f..5a99bae654f3b900f427878ee79cd21039ccba7d 100644
--- a/LayoutTests/media/audio-concurrent-supported.html
+++ b/LayoutTests/media/audio-concurrent-supported.html
@@ -32,14 +32,8 @@
function timeupdateListener(event)
{
- ++timeupdateEventCount;
-
- // wait 2 timeupdate events so we are sure the media engine is
- // playing the media.
- if (timeupdateEventCount >= 2) {
- // make sure time is advancing
- testElement = this;
- testExpected(audioElementCount + ", testElement.currentTime", 0, '>');
+ // Make sure time is advancing.
+ if (this.currentTime > 0) {
this.removeEventListener('timeupdate', timeupdateListener);
if (++audioElementCount >= maxPlayers) {
// All audio elements have been started playing. Make sure
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/media/audio-concurrent-supported-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698