LayoutTests/media/media-controller-effective-playback-rate.html - Issue 574883002: Fix media layout tests that made invalid assumptions about timeupdate.

Side by Side Diff: LayoutTests/media/media-controller-effective-playback-rate.html

Issue 574883002: Fix media layout tests that made invalid assumptions about timeupdate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/media/audio-concurrent-supported-expected.txt ('k') | LayoutTests/media/media-controller-effective-playback-rate-expected.txt » ('j') | LayoutTests/media/media-controller-playbackrate.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test effective playback rate with a MediaController.</title>	4 <title>Test effective playback rate with a MediaController.</title>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="video-test.js"></script>	6 <script src="video-test.js"></script>

7 <script>	7 <script>

8 var start = function()	8 var start = function()

9 {	9 {

10 findMediaElement();	10 findMediaElement();

11 video.src = findMediaFile("video", "content/test");	11 video.src = findMediaFile("video", "content/test");

12	12

13 // Set the rate on the media element so playback won't move forw ard.	13 // Set the rate on the media element so playback won't move forw ard.

14 video.playbackRate = 0;	14 video.playbackRate = 0;

15	15

16 waitForEvent("canplay",canplay);	16 waitForEvent("canplay",canplay);

17 };	17 };

18	18

19 var canplay = function()	19 var canplay = function()

20 {	20 {

21 video.controller = new MediaController();	21 video.controller = new MediaController();

22	22

23 // Verify the controller playback rate is 1. This	23 // Verify the controller playback rate is 1. This

24 // means the "effective playback rate" is 1 even though	24 // means the "effective playback rate" is 1 even though

25 // the HTMLMediaElement's playbackRate attribute is 0.	25 // the HTMLMediaElement's playbackRate attribute is 0.

26 testExpected("video.controller.playbackRate", 1);	26 testExpected("video.controller.playbackRate", 1);

27 testExpected("video.playbackRate", 0);	27 testExpected("video.playbackRate", 0);

28	28

	29 // Wait for bringing up to speed step to complete.
	acolwell GONE FROM CHROMIUM 2014/09/16 21:46:13 nit: perhaps mention that "bringing up to speed" i nit: perhaps mention that "bringing up to speed" initiates a seek on the media element so this is a little more obvious w/o looking at the spec. scherkus (not reviewing) 2014/09/16 22:13:31 Done. Show quoted text On 2014/09/16 21:46:13, acolwell_leaving_chromium_9-23 wrote: > nit: perhaps mention that "bringing up to speed" initiates a seek on the media > element so this is a little more obvious w/o looking at the spec. Done.
	30 waitForEventOnce('seeked', seeked);

	31 };

	32

	33 var seeked = function()

	34 {

29 // Initiate playback and verify that time moves forward.	35 // Initiate playback and verify that time moves forward.

30 run("video.play()");	36 run("video.play()");

31 waitForEventOnce("play", play);	37 waitForEventOnce("play", play);

32 };	38 };

33	39

34 var play = function()	40 var play = function()

35 {	41 {

36 waitForEventOnce("timeupdate", timeupdate);	42 waitForEventOnce("timeupdate", timeupdate);

37 };	43 };

38	44

39 var timeupdate = function() {	45 var timeupdate = function() {

40 testExpected("video.currentTime", 0, "!=");	46 testExpected("video.currentTime", 0, "!=");

41 endTest();	47 endTest();

42 };	48 };

43 </script>	49 </script>

44 </head>	50 </head>

45 <body onload="start()">	51 <body onload="start()">

46 <video></video>	52 <video></video>

47 </body>	53 </body>

48 </html>	54 </html>

OLD	NEW