Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 574623004: GuestViewContainer lifetime should only be managed by BrowserPlugin and not RenderFrameObserver (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GuestViewContainer lifetime should only be managed by BrowserPlugin and not RenderFrameObserver This prevents racy teardowns that might cause BrowserPlugin to try to delete an invalid pointer BUG=none Test=Open browser sample, and close browser sample. It should not crash. TBR=lazyboy@chromium.org Committed: https://crrev.com/b4e3817fa26c6c53ea930beab249c51d0370bd31 Cr-Commit-Position: refs/heads/master@{#295127}

Patch Set 1 #

Patch Set 2 : Removed unnecessary change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
6 years, 3 months ago (2014-09-16 17:12:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574623004/20001
6 years, 3 months ago (2014-09-16 17:22:21 UTC) #4
lazyboy
lgtm
6 years, 3 months ago (2014-09-16 17:34:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1e8b7f4c9d5e155e7532c78bb04bb37f8b3af636
6 years, 3 months ago (2014-09-16 19:41:56 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:43:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4e3817fa26c6c53ea930beab249c51d0370bd31
Cr-Commit-Position: refs/heads/master@{#295127}

Powered by Google App Engine
This is Rietveld 408576698