extensions/renderer/guest_view/guest_view_container.h - Issue 574623004: GuestViewContainer lifetime should only be managed by BrowserPlugin and not RenderFrameObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_container.h

Issue 574623004: GuestViewContainer lifetime should only be managed by BrowserPlugin and not RenderFrameObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary change Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/guest_view/guest_view_container.h

diff --git a/extensions/renderer/guest_view/guest_view_container.h b/extensions/renderer/guest_view/guest_view_container.h

index a5695a2e34f7756c765eeb916821767fafccd8bb..68db47fe21cd5639e52cca531fee57270dabef71 100644

--- a/extensions/renderer/guest_view/guest_view_container.h

+++ b/extensions/renderer/guest_view/guest_view_container.h

@@ -26,6 +26,7 @@ class GuestViewContainer : public content::BrowserPluginDelegate,

virtual void DidReceiveData(const char* data, int data_length) OVERRIDE;

// RenderFrameObserver override.

+ virtual void OnDestruct() OVERRIDE;

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

private:

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | extensions/renderer/guest_view/guest_view_container.cc » ('j') | no next file with comments »