Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: extensions/renderer/guest_view/guest_view_container.cc

Issue 574623004: GuestViewContainer lifetime should only be managed by BrowserPlugin and not RenderFrameObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unnecessary change Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/guest_view/guest_view_container.cc
diff --git a/extensions/renderer/guest_view/guest_view_container.cc b/extensions/renderer/guest_view/guest_view_container.cc
index 05ccf68bbe376603f3e6da4da2f67a6bf688da2e..40051b103c17c11d8fc4aa180bdecc6448709a3c 100644
--- a/extensions/renderer/guest_view/guest_view_container.cc
+++ b/extensions/renderer/guest_view/guest_view_container.cc
@@ -23,8 +23,7 @@ GuestViewContainer::GuestViewContainer(
GuestViewContainer::~GuestViewContainer() {
}
-void GuestViewContainer::SetElementInstanceID(
- int element_instance_id) {
+void GuestViewContainer::SetElementInstanceID(int element_instance_id) {
element_instance_id_ = element_instance_id;
}
@@ -42,6 +41,11 @@ void GuestViewContainer::DidReceiveData(const char* data, int data_length) {
html_string_ += value;
}
+void GuestViewContainer::OnDestruct() {
+ // GuestViewContainer's lifetime is managed by BrowserPlugin so don't let
+ // RenderFrameObserver self-destruct here.
+}
+
bool GuestViewContainer::OnMessageReceived(const IPC::Message& message) {
if (message.type() != ExtensionMsg_CreateMimeHandlerViewGuestACK::ID)
return false;
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698