Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 574313002: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/history" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/37571758dd8c08439ce7a135463ccb57b958af99 Cr-Commit-Position: refs/heads/master@{#295926}

Patch Set 1 #

Patch Set 2 : fixing build issue #

Patch Set 3 : fixing build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/history/top_sites_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Anand Ratn (left samsung)
brettw@chromium.org: Please review changes in src/chrome/browser/history module jochen@chromium.org: Please review changes in src/chrome/browser/history module thestig@chromium.org: ...
6 years, 3 months ago (2014-09-17 10:18:16 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-17 18:13:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574313002/1
6 years, 3 months ago (2014-09-22 05:20:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/58849)
6 years, 3 months ago (2014-09-22 05:22:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574313002/40001
6 years, 3 months ago (2014-09-22 05:46:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 7306da0048881a6572cbef0ceccb1faebf270c08
6 years, 3 months ago (2014-09-22 06:15:49 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 06:16:30 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/37571758dd8c08439ce7a135463ccb57b958af99
Cr-Commit-Position: refs/heads/master@{#295926}

Powered by Google App Engine
This is Rietveld 408576698