Declaring the weak_ptr_factory in proper order.

chrome/browser/history/top_sites_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task/cancelable_task_tracker.h"
@@ skipping 37 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(WaitForHistoryTask);
 };
 
 // Used for querying top sites. Either runs sequentially, or runs a nested
 // nested message loop until the response is complete. The later is used when
 // TopSites is queried before it finishes loading.
 class TopSitesQuerier {
  public:
   TopSitesQuerier()
-      : weak_ptr_factory_(this),
-        number_of_callbacks_(0),
-        waiting_(false) {}
+      : number_of_callbacks_(0),
+        waiting_(false),
+        weak_ptr_factory_(this) {}
 
   // Queries top sites. If |wait| is true a nested message loop is run until the
   // callback is notified.
   void QueryTopSites(TopSitesImpl* top_sites, bool wait) {
     QueryAllTopSites(top_sites, wait, false);
   }
 
   // Queries top sites, including potentially forced URLs if
   // |include_forced_urls| is true.
   void QueryAllTopSites(TopSitesImpl* top_sites,
@@ skipping 23 matching lines @@
   // Callback for TopSitesImpl::GetMostVisitedURLs.
   void OnTopSitesAvailable(const history::MostVisitedURLList& data) {
     urls_ = data;
     number_of_callbacks_++;
     if (waiting_) {
       base::MessageLoop::current()->Quit();
       waiting_ = false;
     }
   }
 
-  base::WeakPtrFactory<TopSitesQuerier> weak_ptr_factory_;
   MostVisitedURLList urls_;
   int number_of_callbacks_;
   bool waiting_;
+  base::WeakPtrFactory<TopSitesQuerier> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TopSitesQuerier);
 };
 
 // Extracts the data from |t1| into a SkBitmap. This is intended for usage of
 // thumbnail data, which is stored as jpgs.
 SkBitmap ExtractThumbnail(const base::RefCountedMemory& t1) {
   scoped_ptr<SkBitmap> image(gfx::JPEGCodec::Decode(t1.front(),
                                                     t1.size()));
   return image.get() ? *image : SkBitmap();
@@ skipping 1449 matching lines @@
   ASSERT_EQ(orig_thumbnail.getSize(), thumbnail.getSize());
   orig_thumbnail.lockPixels();
   thumbnail.lockPixels();
   EXPECT_EQ(0, memcmp(orig_thumbnail.getPixels(), thumbnail.getPixels(),
                       orig_thumbnail.getSize()));
   thumbnail.unlockPixels();
   orig_thumbnail.unlockPixels();
 }
 
 }  // namespace history