Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/history/top_sites_impl_unittest.cc

Issue 574313002: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing build issue Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/top_sites_impl_unittest.cc
diff --git a/chrome/browser/history/top_sites_impl_unittest.cc b/chrome/browser/history/top_sites_impl_unittest.cc
index 044f3bc2eeb80839338cf3ff56497ae1b95c572f..9a8da198742d1a3c9849de7144467ecb1e5972d3 100644
--- a/chrome/browser/history/top_sites_impl_unittest.cc
+++ b/chrome/browser/history/top_sites_impl_unittest.cc
@@ -55,9 +55,9 @@ class WaitForHistoryTask : public HistoryDBTask {
class TopSitesQuerier {
public:
TopSitesQuerier()
- : weak_ptr_factory_(this),
- number_of_callbacks_(0),
- waiting_(false) {}
+ : number_of_callbacks_(0),
+ waiting_(false),
+ weak_ptr_factory_(this) {}
// Queries top sites. If |wait| is true a nested message loop is run until the
// callback is notified.
@@ -101,10 +101,10 @@ class TopSitesQuerier {
}
}
- base::WeakPtrFactory<TopSitesQuerier> weak_ptr_factory_;
MostVisitedURLList urls_;
int number_of_callbacks_;
bool waiting_;
+ base::WeakPtrFactory<TopSitesQuerier> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(TopSitesQuerier);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698