third_party/closure_compiler/processor.py - Issue 574193002: Compile print_preview, part 1: remove all warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/processor.py

Issue 574193002: Compile print_preview, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/compiled_resources.gyp ('K') | « chrome/browser/resources/print_preview/settings/page_settings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/processor.py

diff --git a/third_party/closure_compiler/processor.py b/third_party/closure_compiler/processor.py

index be6b79772009e39f8ef4ce8a27df990047632739..4368a2f2755cc43a31b9bfa9e703c370099e0144 100644

--- a/third_party/closure_compiler/processor.py

+++ b/third_party/closure_compiler/processor.py

@@ -73,7 +73,7 @@ class Processor(object):

"""

_IF_TAGS_REG = "</?if[^>]*?>"

- _INCLUDE_REG = "<include[^>]+src=['\"]([^>]*)['\"]>"

+ _INCLUDE_REG = "<include[^>]+src=['\"]([^>]*)['\"] ?/?>"

Dan Beam 2014/09/19 21:51:53 remove, https://codereview.chromium.org/588673003

Vitaly Pavlenko 2014/09/19 21:59:33 I added it because there's a lot of such code: htt

Dan Beam 2014/09/19 22:07:37 not gradually, no: https://codereview.chromium.org

Vitaly Pavlenko 2014/09/19 22:20:17 Ok, reverted my changes.

def __init__(self, source_file):

self._included_files = set()

« chrome/browser/resources/print_preview/compiled_resources.gyp ('K') | « chrome/browser/resources/print_preview/settings/page_settings.js ('k') | no next file » | no next file with comments »