Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 573963004: Make the proxy override bubble sticky (not dismiss on focus-loss). (Closed)

Created:
6 years, 3 months ago by Finnur
Modified:
6 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the proxy override bubble sticky (not dismiss on focus-loss). It likely shows at startup and we have complaints about people not being able to read it before it goes away (probably due to the focus-storm at startup). BUG=None Committed: https://crrev.com/8f5b150862d1e46f048d09b61307a025e095df9b Cr-Commit-Position: refs/heads/master@{#295076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/proxy_overridden_bubble_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Finnur
If this is palatable, please check the Commit checkbox. Thanks!
6 years, 3 months ago (2014-09-16 12:15:55 UTC) #2
Devlin
LGTM. We want to be sure to be careful when using CloseOnDeactivate(), so as not ...
6 years, 3 months ago (2014-09-16 15:36:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573963004/1
6 years, 3 months ago (2014-09-16 15:37:10 UTC) #5
Finnur
Yeah, I know. I've already mentioned to Alex Ainslie that we should change the behavior ...
6 years, 3 months ago (2014-09-16 15:46:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as c669b9cb4c89a6103d891b96f0352565a7b61358
6 years, 3 months ago (2014-09-16 16:02:17 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:03:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f5b150862d1e46f048d09b61307a025e095df9b
Cr-Commit-Position: refs/heads/master@{#295076}

Powered by Google App Engine
This is Rietveld 408576698