Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350713002: Enable editing of content settings type Notifications. (Closed)

Created:
5 years, 3 months ago by finnur1
Modified:
5 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable editing of content settings type Notifications. BUG=529503 Committed: https://crrev.com/e6950ae588e6aabe1ae4125eac29707c890bd619 Cr-Commit-Position: refs/heads/master@{#350139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/options/content_settings_exceptions_area.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 573963004 Patch 1

Messages

Total messages: 15 (6 generated)
Finnur
5 years, 3 months ago (2015-09-16 14:46:56 UTC) #2
Finnur
dbeam: Ping...
5 years, 3 months ago (2015-09-18 09:37:31 UTC) #3
Finnur
James, looks like Dan is out. Can you take a look?
5 years, 3 months ago (2015-09-21 16:17:34 UTC) #5
Dan Beam
lgtm
5 years, 3 months ago (2015-09-21 16:55:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350713002/1
5 years, 3 months ago (2015-09-22 09:56:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/107092)
5 years, 3 months ago (2015-09-22 10:44:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350713002/1
5 years, 3 months ago (2015-09-22 10:55:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 11:31:27 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 12:07:57 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6950ae588e6aabe1ae4125eac29707c890bd619
Cr-Commit-Position: refs/heads/master@{#350139}

Powered by Google App Engine
This is Rietveld 408576698