chrome/browser/extensions/proxy_overridden_bubble_controller.cc - Issue 573963004: Make the proxy override bubble sticky (not dismiss on focus-loss).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.cc

Issue 573963004: Make the proxy override bubble sticky (not dismiss on focus-loss). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/proxy_overridden_bubble_controller.h"	5 #include "chrome/browser/extensions/proxy_overridden_bubble_controller.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "chrome/browser/extensions/extension_service.h"	8 #include "chrome/browser/extensions/extension_service.h"

9 #include "chrome/browser/extensions/extension_toolbar_model.h"	9 #include "chrome/browser/extensions/extension_toolbar_model.h"

10 #include "chrome/browser/extensions/settings_api_helpers.h"	10 #include "chrome/browser/extensions/settings_api_helpers.h"

(...skipping 194 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
205 bool ProxyOverriddenBubbleController::ShouldShow(	205 bool ProxyOverriddenBubbleController::ShouldShow(

206 const std::string& extension_id) {	206 const std::string& extension_id) {

207 if (!delegate()->ShouldIncludeExtension(extension_id))	207 if (!delegate()->ShouldIncludeExtension(extension_id))

208 return false;	208 return false;

209	209

210 delegate()->RestrictToSingleExtension(extension_id);	210 delegate()->RestrictToSingleExtension(extension_id);

211 return true;	211 return true;

212 }	212 }

213	213

214 bool ProxyOverriddenBubbleController::CloseOnDeactivate() {	214 bool ProxyOverriddenBubbleController::CloseOnDeactivate() {

215 return true;	215 return false;

216 }	216 }

217	217

218 } // namespace extensions	218 } // namespace extensions

OLD	NEW