Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/history_menu_bridge.h
diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.h b/chrome/browser/ui/cocoa/history_menu_bridge.h
index aa6c3d3e72c217ad3657425226b4fe29f6ba03dc..e013a026614f04f92c32bc5689d65ff0c4536d1d 100644
--- a/chrome/browser/ui/cocoa/history_menu_bridge.h
+++ b/chrome/browser/ui/cocoa/history_menu_bridge.h
@@ -17,6 +17,7 @@
#include "chrome/browser/sessions/tab_restore_service.h"
#include "chrome/browser/sessions/tab_restore_service_observer.h"
#import "chrome/browser/ui/cocoa/main_menu_item.h"
+#include "components/history/core/browser/history_service_observer.h"
#include "components/sessions/session_id.h"
#include "content/public/browser/notification_observer.h"
@@ -58,7 +59,8 @@ struct FaviconImageResult;
// class does the bulk of the work.
class HistoryMenuBridge : public content::NotificationObserver,
public TabRestoreServiceObserver,
- public MainMenuItem {
+ public MainMenuItem,
+ public history::HistoryServiceObserver {
public:
// This is a generalization of the data we store in the history menu because
// we pull things from different sources with different data types.
@@ -148,6 +150,9 @@ class HistoryMenuBridge : public content::NotificationObserver,
HistoryService* service();
Profile* profile();
+ // Is called when |service| is loaded.
sdefresne 2014/10/20 13:15:42 // history::HistoryServiceObserver:
nshaik 2014/10/29 08:43:39 Done.
+ virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;
sdefresne 2014/10/20 13:15:42 OVERRIDE -> override
nshaik 2014/10/29 08:43:39 Done.
+
protected:
// Return the History menu.
virtual NSMenu* HistoryMenu();

Powered by Google App Engine
This is Rietveld 408576698