chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc - Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

index 3c00de5cf5e04a317d4fe715ec9bd2a8a4297b5f..6f19e67b8698def689c23be2e47df093b7a9a09f 100644

--- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

+++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

@@ -230,10 +230,7 @@ TEST_F(SyncBookmarkDataTypeControllerTest, StartHistoryServiceNotReady) {

EXPECT_CALL(*history_service_, BackendLoaded()).WillRepeatedly(Return(true));

// Send the notification that the history service has finished loading the db.

- content::NotificationService::current()->Notify(

- chrome::NOTIFICATION_HISTORY_LOADED,

- content::Source<Profile>(&profile_),

- content::NotificationService::NoDetails());

+ history_service_->NotifyHistoryServiceLoaded();

EXPECT_EQ(DataTypeController::MODEL_LOADED, bookmark_dtc_->state());

}