Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 571463002: Factor out common code from RenderSVGResource*::postApplyResource (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Factor out common code from RenderSVGResource*::postApplyResource Factor the fill/stroke code out of the various paint-server RenderSVGResource subclasses and move it to SVGRenderSupport. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -42 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceGradient.cpp View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
6 years, 3 months ago (2014-09-12 12:03:57 UTC) #2
kouhei (in TOK)
lgtm
6 years, 3 months ago (2014-09-12 14:07:08 UTC) #3
f(malita)
lgtm! (i've been thinking we need to refine the resource type hierarchy: gradient/pattern/solidcolor/markers really are ...
6 years, 3 months ago (2014-09-12 14:10:35 UTC) #4
fs
On 2014/09/12 14:10:35, Florin Malita wrote: > lgtm! > > (i've been thinking we need ...
6 years, 3 months ago (2014-09-12 14:32:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571463002/1
6 years, 3 months ago (2014-09-12 14:32:33 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 14:37:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181907

Powered by Google App Engine
This is Rietveld 408576698