Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 570733002: Add support for glMemoryGlyphIndexArrayNV (Closed)

Created:
6 years, 3 months ago by Chris Dalton
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Mark Kilgard
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Adds glMemoryGlyphIndexArrayNV to the GrGLInterface and begins detecting support for this method in GrGLPathRendering. BUG=skia:2939 Committed: https://skia.googlesource.com/skia/+/149b3ec2b1ccaf00e40bf296d2a3394852d73fe9

Patch Set 1 #

Patch Set 2 : Fix windows warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Chris Dalton
6 years, 3 months ago (2014-09-12 22:18:07 UTC) #2
Kimmo Kinnunen
Btw: would it be useful for us to file a skia issue describing briefly how ...
6 years, 3 months ago (2014-09-15 07:59:17 UTC) #3
bsalomon
lgtm. WRT Kimmo's question: I think that'd be useful for us to track what you ...
6 years, 3 months ago (2014-09-15 14:06:11 UTC) #4
Chris Dalton
On 2014/09/15 14:06:11, bsalomon wrote: > lgtm. WRT Kimmo's question: I think that'd be useful ...
6 years, 3 months ago (2014-09-16 06:45:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570733002/1
6 years, 3 months ago (2014-09-16 22:22:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1807)
6 years, 3 months ago (2014-09-16 22:36:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570733002/20001
6 years, 3 months ago (2014-09-17 16:12:25 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 16:19:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 149b3ec2b1ccaf00e40bf296d2a3394852d73fe9

Powered by Google App Engine
This is Rietveld 408576698