Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 569683004: Factor painting code from RenderBlock into BlockPainter. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, slimming-paint-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Factor painting code from RenderBlock into BlockPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182016

Patch Set 1 #

Patch Set 2 : Finish. #

Total comments: 10

Patch Set 3 : Fix. #

Patch Set 4 : Fix. #

Patch Set 5 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -481 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/paint/BlockPainter.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A Source/core/paint/BlockPainter.cpp View 1 2 3 4 1 chunk +476 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineBox.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 3 4 8 chunks +19 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 4 7 chunks +18 lines, -441 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
chrishtr
6 years, 3 months ago (2014-09-15 17:03:00 UTC) #2
chrishtr
6 years, 3 months ago (2014-09-15 17:03:17 UTC) #3
Stephen Chennney
https://codereview.chromium.org/569683004/diff/20001/Source/core/paint/BlockPainter.cpp File Source/core/paint/BlockPainter.cpp (right): https://codereview.chromium.org/569683004/diff/20001/Source/core/paint/BlockPainter.cpp#newcode60 Source/core/paint/BlockPainter.cpp:60: m_renderBlock.paintObject(paintInfo, adjustedPaintOffset); FIXME on all the refs like this ...
6 years, 3 months ago (2014-09-15 20:18:05 UTC) #5
chrishtr
Thanks for the timely review. https://codereview.chromium.org/569683004/diff/20001/Source/core/paint/BlockPainter.cpp File Source/core/paint/BlockPainter.cpp (right): https://codereview.chromium.org/569683004/diff/20001/Source/core/paint/BlockPainter.cpp#newcode60 Source/core/paint/BlockPainter.cpp:60: m_renderBlock.paintObject(paintInfo, adjustedPaintOffset); On 2014/09/15 ...
6 years, 3 months ago (2014-09-15 20:52:08 UTC) #6
Stephen Chennney
Lets see what the CQ has to say. I'm happy as is. LGTM
6 years, 3 months ago (2014-09-15 21:15:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569683004/40001
6 years, 3 months ago (2014-09-15 21:16:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569683004/60001
6 years, 3 months ago (2014-09-15 21:30:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/24916) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56179)
6 years, 3 months ago (2014-09-15 21:41:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569683004/80001
6 years, 3 months ago (2014-09-15 21:53:13 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 22:59:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 182016

Powered by Google App Engine
This is Rietveld 408576698