Refactoring the order of the weak_ptr_factory in chrome/renderer folder

Refactoring the order of the weak_ptr_factory in chrome/renderer folder

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/352bb45047c1fce4203fe9893893f2fbf352d716
Cr-Commit-Position: refs/heads/master@{#294861}

[MRV, 2014-09-15 13:49:16]

mohan.reddy@samsung.com changed reviewers:
+ sky@chromium.org

[MRV, 2014-09-15 13:49:16]

PTAL

[sky, 2014-09-15 16:13:11]

LGTM - I'll also say unless you add a presubmit check for this, it'll keep
regressing.

[MRV, 2014-09-15 17:05:04]

On 2014/09/15 16:13:11, sky wrote:
> LGTM - I'll also say unless you add a presubmit check for this, it'll keep
> regressing.

Dear mr.sky.. thanks for lgtm.
I'll consider your suggestion.. and will try adding check in presubmit

[MRV, 2014-09-15 17:05:22]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-15 17:18:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569233002/1

[commit-bot: I haz the power, 2014-09-15 19:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 19:12:01]

Failed to commit the patch.

[commit-bot: I haz the power, 2014-09-15 19:14:37]

Patchset 1 (id:??) landed as
https://crrev.com/352bb45047c1fce4203fe9893893f2fbf352d716
Cr-Commit-Position: refs/heads/master@{#294861}

[MRV, 2014-09-16 02:04:11]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-16 02:19:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569233002/1

[commit-bot: I haz the power, 2014-09-16 02:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 02:21:57]

Failed to apply patch for
chrome/renderer/extensions/cast_streaming_native_handler.h:
While running git apply --index -p1;
  error: patch failed:
chrome/renderer/extensions/cast_streaming_native_handler.h:85
  error: chrome/renderer/extensions/cast_streaming_native_handler.h: patch does
not apply

Patch:       chrome/renderer/extensions/cast_streaming_native_handler.h
Index: chrome/renderer/extensions/cast_streaming_native_handler.h
diff --git a/chrome/renderer/extensions/cast_streaming_native_handler.h
b/chrome/renderer/extensions/cast_streaming_native_handler.h
index
ee0626d62a6a4566e40f0d2d95b64068c0a31f2d..92e76a107339e7c486d4aabda31d5fa94413af49
100644
--- a/chrome/renderer/extensions/cast_streaming_native_handler.h
+++ b/chrome/renderer/extensions/cast_streaming_native_handler.h
@@ -85,8 +85,6 @@ class CastStreamingNativeHandler : public
ObjectBackedNativeHandler {
   typedef std::map<int, linked_ptr<CastUdpTransport> > UdpTransportMap;
   UdpTransportMap udp_transport_map_;
 
-  base::WeakPtrFactory<CastStreamingNativeHandler> weak_factory_;
-
   extensions::ScopedPersistent<v8::Function> create_callback_;
 
   typedef std::map<int,
@@ -95,6 +93,8 @@ class CastStreamingNativeHandler : public
ObjectBackedNativeHandler {
   RtpStreamCallbackMap get_raw_events_callbacks_;
   RtpStreamCallbackMap get_stats_callbacks_;
 
+  base::WeakPtrFactory<CastStreamingNativeHandler> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(CastStreamingNativeHandler);
 };