components/data_reduction_proxy/browser/data_reduction_proxy_params.h - Issue 568893002: Trigger data reduction proxy unreachable message via on proxy fall back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Issue 568893002: Trigger data reduction proxy unreachable message via on proxy fall back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed bengr's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_params.cc » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h

index f9ec3a308c7e1da00ae33ad9a3cd18d1bedf2d47..72b2c01a67fbade7a664962abd4979b340925a87 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h

@@ -126,11 +126,6 @@ class DataReductionProxyParams {

const net::HostPortPair& host_port_pair,

DataReductionProxyTypeInfo* proxy_info) const;

- // Returns true if this request will be sent through the data request proxy

- // based on applying the param rules to the URL. We do not check bad proxy

- // list.

- virtual bool IsDataReductionProxyEligible(const net::URLRequest* request);

// Returns true if this request would be bypassed by the data request proxy

// based on applying the |data_reduction_proxy_config| param rules to the

// request URL.