Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params.cc

Issue 568893002: Trigger data reduction proxy unreachable message via on proxy fall back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr's comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
index 43d0795a573ce019e49491ef52d8bcc3a916862d..c11e372132aab5ee64646b8cd51f3134628a9fe6 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
@@ -352,23 +352,6 @@ bool DataReductionProxyParams::IsDataReductionProxy(
return false;
}
-// TODO(kundaji): Check that the request will actually be sent through the
-// proxy.
-bool DataReductionProxyParams::IsDataReductionProxyEligible(
- const net::URLRequest* request) {
- DCHECK(request);
- DCHECK(request->context());
- DCHECK(request->context()->proxy_service());
- net::ProxyInfo result;
- request->context()->proxy_service()->config().proxy_rules().Apply(
- request->url(), &result);
- if (!result.proxy_server().is_valid())
- return false;
- if (result.proxy_server().is_direct())
- return false;
- return IsDataReductionProxy(result.proxy_server().host_port_pair(), NULL);
-}
-
bool DataReductionProxyParams::IsBypassedByDataReductionProxyLocalRules(
const net::URLRequest& request,
const net::ProxyConfig& data_reduction_proxy_config) const {

Powered by Google App Engine
This is Rietveld 408576698