Trigger data reduction proxy unreachable message via on proxy fall back.

components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

Index: components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
index 33fd29e560fa2f533fa044f1c3be60a83537c599..b0a9eed65f98bc86bad8adf1624de8301b3a8cbb 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
@@ -64,8 +64,10 @@ class DataReductionProxyUsageStats
       const BooleanPrefMember& data_reduction_proxy_enabled,
       const net::ProxyConfig& data_reduction_proxy_config);
 
-  void RecordBypassEventHistograms(const net::ProxyServer& bypassed_proxy,
-                                   int net_error) const;
+  // Called by |ChromeNetworkDelegate| when a proxy is put into bad proxy list.

[bengr, 2014/09/19 21:28:13]

nit: "into the"

[Not at Google. Contact bengr, 2014/09/22 21:46:58]

Done.

+  // Used to track when data reduction proxy falls back.

[bengr, 2014/09/19 21:28:12]

nit: "when the"

[Not at Google. Contact bengr, 2014/09/22 21:46:58]

Done.

+  void OnProxyFallback(const net::ProxyServer& bypassed_proxy,
+                       int net_error);
 
  private:
   enum BypassedBytesType {
@@ -83,9 +85,6 @@ class DataReductionProxyUsageStats
   virtual void OnNetworkChanged(
       net::NetworkChangeNotifier::ConnectionType type) OVERRIDE;
 
-  // Counts requests that went through the data reduction proxy and counts
-  // requests that were eligible to go through the proxy.
-  void IncrementRequestCounts(bool actual);
   void ClearRequestCounts();
 
   // Checks if the availability status of the data reduction proxy has changed,
@@ -110,14 +109,12 @@ class DataReductionProxyUsageStats
   // unreachable if no successful requests are made through it despite a
   // non-zero number of requests being eligible.
 
-  // Count of requests which will be tried to be sent through data reduction
-  // proxy. The count is only based on the config and not the bad proxy list.
-  // Explicit bypasses are not part of this count. This is the desired behavior
-  // since otherwise both counts would be identical.
-  unsigned long eligible_num_requests_through_proxy_;
-
   // Count of successful requests through data reduction proxy.

[bengr, 2014/09/19 21:28:13]

nit: "through the"

[Not at Google. Contact bengr, 2014/09/22 21:46:58]

Done.

-  unsigned long actual_num_requests_through_proxy_;
+  unsigned long num_successful_requests_through_proxy_;

[bengr, 2014/09/19 21:28:12]

I don't like "num". If you don't like the removal of it, change to:
successful_requests_through_proxy_count_ and proxy_net_errors_count_.

[Not at Google. Contact bengr, 2014/09/22 21:46:58]

Done.

Would have preferred count_successful_requests_through_proxy_, because that way
I don't have to read the entire variable name to realize its a count. But
changing to what you suggested for now.

+
+  // Count of network errors encountered when connecting to a data reduction
+  // proxy.
+  unsigned long num_proxy_net_errors_;
 
   // Whether or not the data reduction proxy is unavailable.
   bool unavailable_;