content/browser/renderer_host/render_widget_host_view_android.h - Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index c41252dcd0eaf50a420659e9b22ec277c131e200..c7ec65a768c7a6fc93f44125b387a18b1a7e381b 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -383,7 +383,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

// The output surface id of the last received frame.

uint32_t last_output_surface_id_;

- base::WeakPtrFactory<RenderWidgetHostViewAndroid> weak_ptr_factory_;

std::queue<base::Closure> ack_callbacks_;

@@ -434,6 +433,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

// The last scroll offset of the view.

gfx::Vector2dF last_scroll_offset_;

+ base::WeakPtrFactory<RenderWidgetHostViewAndroid> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAndroid);

};