Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 567783002: Add modifier flags to MotionEvent (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
sadrul, tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add modifier flags to MotionEvent Allow event modifier flags to propagate through the touch and/or gestures derived from a MotionEvent. This allows, for example, ctrl + tap to mimic ctrl + click. Note that, previously, Aura routed these modifier flags separately, and Android failed to route them at all. BUG=398439, 413335 Committed: https://crrev.com/36f186d9260f10ab4b134987d369d0dd93f298ff Cr-Commit-Position: refs/heads/master@{#294695}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove MotionEvent modifiers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -71 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_text_selector_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_android.h View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_android.cc View 6 chunks +28 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_android_unittest.cc View 6 chunks +11 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_web.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_web.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 4 chunks +55 lines, -0 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 2 chunks +1 line, -25 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 11 chunks +22 lines, -11 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 11 chunks +21 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.h View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 4 chunks +12 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 8 chunks +40 lines, -12 lines 0 comments Download
M ui/events/gestures/gesture_provider_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_provider_aura.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/events/gestures/motion_event_aura.h View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M ui/events/gestures/motion_event_aura_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jdduke (slow)
PTAL, thanks. sadrul@: content/browser/renderer_host, content/browser/renderer_host/input tdresser@: ui/events/gesture_detection/, ui/events/gestures
6 years, 3 months ago (2014-09-11 20:03:14 UTC) #2
tdresser
https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h#newcode43 ui/events/gesture_detection/motion_event.h:43: enum Modifiers { Where are these used?
6 years, 3 months ago (2014-09-11 20:51:18 UTC) #3
jdduke (slow)
https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h#newcode43 ui/events/gesture_detection/motion_event.h:43: enum Modifiers { On 2014/09/11 20:51:18, tdresser wrote: > ...
6 years, 3 months ago (2014-09-11 20:51:57 UTC) #4
jdduke (slow)
https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h#newcode43 ui/events/gesture_detection/motion_event.h:43: enum Modifiers { On 2014/09/11 20:51:57, jdduke wrote: > ...
6 years, 3 months ago (2014-09-11 20:57:18 UTC) #5
tdresser
On 2014/09/11 20:57:18, jdduke wrote: > https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h > File ui/events/gesture_detection/motion_event.h (right): > > https://codereview.chromium.org/567783002/diff/1/ui/events/gesture_detection/motion_event.h#newcode43 > ...
6 years, 3 months ago (2014-09-12 18:49:00 UTC) #6
sadrul
lgtm
6 years, 3 months ago (2014-09-12 22:03:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567783002/20001
6 years, 3 months ago (2014-09-12 22:09:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/15182) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/13336)
6 years, 3 months ago (2014-09-12 22:35:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567783002/20001
6 years, 3 months ago (2014-09-12 22:54:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8b147ad8a16b31a0b8b5af020d05a9f4d9d75776
6 years, 3 months ago (2014-09-12 23:46:07 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 23:52:39 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36f186d9260f10ab4b134987d369d0dd93f298ff
Cr-Commit-Position: refs/heads/master@{#294695}

Powered by Google App Engine
This is Rietveld 408576698