Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: content/browser/renderer_host/input/motion_event_android_unittest.cc

Issue 567783002: Add modifier flags to MotionEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove MotionEvent modifiers Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <android/input.h>
6
5 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
6 #include "base/float_util.h" 8 #include "base/float_util.h"
7 #include "content/browser/renderer_host/input/motion_event_android.h" 9 #include "content/browser/renderer_host/input/motion_event_android.h"
8 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "ui/events/event_constants.h"
9 12
10 using ui::MotionEvent; 13 using ui::MotionEvent;
11 14
12 namespace content { 15 namespace content {
13 namespace { 16 namespace {
14 const float kPixToDip = 0.5f; 17 const float kPixToDip = 0.5f;
15 18
16 // Corresponds to ACTION_DOWN, see 19 int kAndroidActionDown = AMOTION_EVENT_ACTION_DOWN;
17 // developer.android.com/reference/android/view/MotionEvent.html#ACTION_DOWN. 20
18 int kAndroidActionDown = 0; 21 int kAndroidAltKeyDown = AMETA_ALT_ON;
19 22
20 // Corresponds to TOOL_TYPE_FINGER, see 23 // Corresponds to TOOL_TYPE_FINGER, see
21 // developer.android.com/reference/android/view/MotionEvent.html 24 // developer.android.com/reference/android/view/MotionEvent.html
22 // #TOOL_TYPE_FINGER. 25 // #TOOL_TYPE_FINGER.
23 int kAndroidToolTypeFinger = 1; 26 int kAndroidToolTypeFinger = 1;
24 27
25 // Corresponds to BUTTON_PRIMARY, see 28 // Corresponds to BUTTON_PRIMARY, see
26 // developer.android.com/reference/android/view/MotionEvent.html#BUTTON_PRIMARY. 29 // developer.android.com/reference/android/view/MotionEvent.html#BUTTON_PRIMARY.
27 int kAndroidButtonPrimary = 1; 30 int kAndroidButtonPrimary = 1;
28 31
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 touch_major0, 73 touch_major0,
71 touch_major1, 74 touch_major1,
72 touch_minor0, 75 touch_minor0,
73 touch_minor1, 76 touch_minor1,
74 orientation0, 77 orientation0,
75 orientation1, 78 orientation1,
76 x0 + raw_offset, 79 x0 + raw_offset,
77 y0 - raw_offset, 80 y0 - raw_offset,
78 kAndroidToolTypeFinger, 81 kAndroidToolTypeFinger,
79 kAndroidToolTypeFinger, 82 kAndroidToolTypeFinger,
80 kAndroidButtonPrimary); 83 kAndroidButtonPrimary,
84 kAndroidAltKeyDown);
81 85
82 EXPECT_EQ(MotionEvent::ACTION_DOWN, event.GetAction()); 86 EXPECT_EQ(MotionEvent::ACTION_DOWN, event.GetAction());
83 EXPECT_EQ(event_time, event.GetEventTime()); 87 EXPECT_EQ(event_time, event.GetEventTime());
84 EXPECT_EQ(x0 * kPixToDip, event.GetX(0)); 88 EXPECT_EQ(x0 * kPixToDip, event.GetX(0));
85 EXPECT_EQ(y0 * kPixToDip, event.GetY(0)); 89 EXPECT_EQ(y0 * kPixToDip, event.GetY(0));
86 EXPECT_EQ(x1 * kPixToDip, event.GetX(1)); 90 EXPECT_EQ(x1 * kPixToDip, event.GetX(1));
87 EXPECT_EQ(y1 * kPixToDip, event.GetY(1)); 91 EXPECT_EQ(y1 * kPixToDip, event.GetY(1));
88 EXPECT_FLOAT_EQ((x0 + raw_offset) * kPixToDip, event.GetRawX(0)); 92 EXPECT_FLOAT_EQ((x0 + raw_offset) * kPixToDip, event.GetRawX(0));
89 EXPECT_FLOAT_EQ((y0 - raw_offset) * kPixToDip, event.GetRawY(0)); 93 EXPECT_FLOAT_EQ((y0 - raw_offset) * kPixToDip, event.GetRawY(0));
90 EXPECT_FLOAT_EQ((x1 + raw_offset) * kPixToDip, event.GetRawX(1)); 94 EXPECT_FLOAT_EQ((x1 + raw_offset) * kPixToDip, event.GetRawX(1));
91 EXPECT_FLOAT_EQ((y1 - raw_offset) * kPixToDip, event.GetRawY(1)); 95 EXPECT_FLOAT_EQ((y1 - raw_offset) * kPixToDip, event.GetRawY(1));
92 EXPECT_EQ(touch_major0 * kPixToDip, event.GetTouchMajor(0)); 96 EXPECT_EQ(touch_major0 * kPixToDip, event.GetTouchMajor(0));
93 EXPECT_EQ(touch_major1 * kPixToDip, event.GetTouchMajor(1)); 97 EXPECT_EQ(touch_major1 * kPixToDip, event.GetTouchMajor(1));
94 EXPECT_EQ(touch_minor0 * kPixToDip, event.GetTouchMinor(0)); 98 EXPECT_EQ(touch_minor0 * kPixToDip, event.GetTouchMinor(0));
95 EXPECT_EQ(touch_minor1 * kPixToDip, event.GetTouchMinor(1)); 99 EXPECT_EQ(touch_minor1 * kPixToDip, event.GetTouchMinor(1));
96 EXPECT_EQ(orientation0, event.GetOrientation(0)); 100 EXPECT_EQ(orientation0, event.GetOrientation(0));
97 EXPECT_EQ(0.f, event.GetOrientation(1)); 101 EXPECT_EQ(0.f, event.GetOrientation(1));
98 EXPECT_EQ(p0, event.GetPointerId(0)); 102 EXPECT_EQ(p0, event.GetPointerId(0));
99 EXPECT_EQ(p1, event.GetPointerId(1)); 103 EXPECT_EQ(p1, event.GetPointerId(1));
100 EXPECT_EQ(MotionEvent::TOOL_TYPE_FINGER, event.GetToolType(0)); 104 EXPECT_EQ(MotionEvent::TOOL_TYPE_FINGER, event.GetToolType(0));
101 EXPECT_EQ(MotionEvent::TOOL_TYPE_FINGER, event.GetToolType(1)); 105 EXPECT_EQ(MotionEvent::TOOL_TYPE_FINGER, event.GetToolType(1));
102 EXPECT_EQ(MotionEvent::BUTTON_PRIMARY, event.GetButtonState()); 106 EXPECT_EQ(MotionEvent::BUTTON_PRIMARY, event.GetButtonState());
107 EXPECT_EQ(ui::EF_ALT_DOWN, event.GetFlags());
103 EXPECT_EQ(static_cast<size_t>(pointer_count), event.GetPointerCount()); 108 EXPECT_EQ(static_cast<size_t>(pointer_count), event.GetPointerCount());
104 EXPECT_EQ(static_cast<size_t>(history_size), event.GetHistorySize()); 109 EXPECT_EQ(static_cast<size_t>(history_size), event.GetHistorySize());
105 EXPECT_EQ(action_index, event.GetActionIndex()); 110 EXPECT_EQ(action_index, event.GetActionIndex());
106 } 111 }
107 112
108 TEST(MotionEventAndroidTest, Clone) { 113 TEST(MotionEventAndroidTest, Clone) {
109 int event_time_ms = 5; 114 int event_time_ms = 5;
110 base::TimeTicks event_time = 115 base::TimeTicks event_time =
111 base::TimeTicks() + base::TimeDelta::FromMilliseconds(event_time_ms); 116 base::TimeTicks() + base::TimeDelta::FromMilliseconds(event_time_ms);
112 float x = 13.7f; 117 float x = 13.7f;
(...skipping 25 matching lines...) Expand all
138 touch_major, 143 touch_major,
139 0.f, 144 0.f,
140 touch_minor, 145 touch_minor,
141 0.f, 146 0.f,
142 orientation, 147 orientation,
143 0.f, 148 0.f,
144 x, 149 x,
145 y, 150 y,
146 0, 151 0,
147 0, 152 0,
153 0,
148 0); 154 0);
149 155
150 scoped_ptr<MotionEvent> clone = event.Clone(); 156 scoped_ptr<MotionEvent> clone = event.Clone();
151 EXPECT_EQ(event, *clone); 157 EXPECT_EQ(event, *clone);
152 } 158 }
153 159
154 TEST(MotionEventAndroidTest, Cancel) { 160 TEST(MotionEventAndroidTest, Cancel) {
155 int event_time_ms = 5; 161 int event_time_ms = 5;
156 base::TimeTicks event_time = 162 base::TimeTicks event_time =
157 base::TimeTicks() + base::TimeDelta::FromMilliseconds(event_time_ms); 163 base::TimeTicks() + base::TimeDelta::FromMilliseconds(event_time_ms);
(...skipping 22 matching lines...) Expand all
180 0.f, 186 0.f,
181 0.f, 187 0.f,
182 0.f, 188 0.f,
183 0.f, 189 0.f,
184 0.f, 190 0.f,
185 0.f, 191 0.f,
186 x, 192 x,
187 y, 193 y,
188 0, 194 0,
189 0, 195 0,
196 0,
190 0); 197 0);
191 198
192 scoped_ptr<MotionEvent> cancel_event = event.Cancel(); 199 scoped_ptr<MotionEvent> cancel_event = event.Cancel();
193 EXPECT_EQ(MotionEvent::ACTION_CANCEL, cancel_event->GetAction()); 200 EXPECT_EQ(MotionEvent::ACTION_CANCEL, cancel_event->GetAction());
194 EXPECT_EQ(event_time, cancel_event->GetEventTime()); 201 EXPECT_EQ(event_time, cancel_event->GetEventTime());
195 EXPECT_EQ(x * kPixToDip, cancel_event->GetX(0)); 202 EXPECT_EQ(x * kPixToDip, cancel_event->GetX(0));
196 EXPECT_EQ(y * kPixToDip, cancel_event->GetY(0)); 203 EXPECT_EQ(y * kPixToDip, cancel_event->GetY(0));
197 EXPECT_EQ(static_cast<size_t>(pointer_count), 204 EXPECT_EQ(static_cast<size_t>(pointer_count),
198 cancel_event->GetPointerCount()); 205 cancel_event->GetPointerCount());
199 EXPECT_EQ(0U, cancel_event->GetHistorySize()); 206 EXPECT_EQ(0U, cancel_event->GetHistorySize());
200 } 207 }
201 208
202 } // namespace content 209 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/input/motion_event_android.cc ('k') | content/browser/renderer_host/input/motion_event_web.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698