Allow ability to name unnamed global addresses in Subzero.

src/llvm2ice.cpp

Index: src/llvm2ice.cpp
diff --git a/src/llvm2ice.cpp b/src/llvm2ice.cpp
index 986ff76ec4a2b2b8ca906dedbecb6fb6a4c629ec..05cde884efd0ffe0c23bd713427976de2aabfc7b 100644
--- a/src/llvm2ice.cpp
+++ b/src/llvm2ice.cpp
@@ -109,6 +109,12 @@ static cl::opt<NaClFileFormat> InputFileFormat(
                clEnumValEnd),
     cl::init(LLVMFormat));
 
+static cl::opt<std::string> DefaultGlobalPrefix(
+    "default-global-prefix",
+    cl::desc("Define default global prefix for naming "
+             "unnamed globals/funtions"),

[Jim Stichnoth, 2014/09/11 22:08:19]

functions

[Karl, 2014/09/12 16:29:06]

Done.

+    cl::init(""));

[jvoung (off chromium), 2014/09/11 22:16:43]

Should this have a default?

At least llc has a default of just "unnamed" (and pnacl-llc has a default of
"Functions" and "Globals"), with no option to change it.

Typically a pexe either has symbols for everything or no symbols at all (except
_start and the intrinsics), so any choice of a default prefix shouldn't actually
conflict?

[Karl, 2014/09/12 16:29:06]

Good point. Changing default for globals to "Global" and functions "Function".

+
 static cl::opt<bool>
 BuildOnRead("build-on-read",
             cl::desc("Build ICE instructions when reading bitcode"),
@@ -143,6 +149,7 @@ int main(int argc, char **argv) {
   Flags.DisableGlobals = DisableGlobals;
   Flags.FunctionSections = FunctionSections;
   Flags.UseSandboxing = UseSandboxing;
+  Flags.DefaultGlobalPrefix = DefaultGlobalPrefix;
 
   Ice::GlobalContext Ctx(Ls, Os, VMask, TargetArch, OptLevel, TestPrefix,
                          Flags);