Allow ability to name unnamed global addresses in Subzero.

src/llvm2ice.cpp

 //===- subzero/src/llvm2ice.cpp - Driver for testing ----------------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file defines a driver that uses LLVM capabilities to parse a
@@ skipping 91 matching lines @@
     DisablePhiEdgeSplit("no-phi-edge-split",
                         cl::desc("Disable edge splitting for Phi lowering"));
 
 static cl::opt<NaClFileFormat> InputFileFormat(
     "bitcode-format", cl::desc("Define format of input file:"),
     cl::values(clEnumValN(LLVMFormat, "llvm", "LLVM file (default)"),
                clEnumValN(PNaClFormat, "pnacl", "PNaCl bitcode file"),
                clEnumValEnd),
     cl::init(LLVMFormat));
 
+static cl::opt<std::string> DefaultGlobalPrefix(
+    "default-global-prefix",
+    cl::desc("Define default global prefix for naming "
+             "unnamed globals/funtions"),

[Jim Stichnoth, 2014/09/11 22:08:19]

functions

[Karl, 2014/09/12 16:29:06]

Done.

+    cl::init(""));

[jvoung (off chromium), 2014/09/11 22:16:43]

Should this have a default?

At least llc has a default of just "unnamed" (and pnacl-llc has a default of
"Functions" and "Globals"), with no option to change it.

Typically a pexe either has symbols for everything or no symbols at all (except
_start and the intrinsics), so any choice of a default prefix shouldn't actually
conflict?

[Karl, 2014/09/12 16:29:06]

Good point. Changing default for globals to "Global" and functions "Function".

+
 static cl::opt<bool>
 BuildOnRead("build-on-read",
             cl::desc("Build ICE instructions when reading bitcode"),
             cl::init(false));
 
 int main(int argc, char **argv) {
 
   cl::ParseCommandLineOptions(argc, argv);
 
   Ice::VerboseMask VMask = Ice::IceV_None;
@@ skipping 14 matching lines @@
   raw_os_ostream *Ls = new raw_os_ostream(LogFilename == "-" ? std::cout : Lfs);
   Ls->SetUnbuffered();
 
   Ice::ClFlags Flags;
   Flags.DisableInternal = DisableInternal;
   Flags.SubzeroTimingEnabled = SubzeroTimingEnabled;
   Flags.DisableTranslation = DisableTranslation;
   Flags.DisableGlobals = DisableGlobals;
   Flags.FunctionSections = FunctionSections;
   Flags.UseSandboxing = UseSandboxing;
+  Flags.DefaultGlobalPrefix = DefaultGlobalPrefix;
 
   Ice::GlobalContext Ctx(Ls, Os, VMask, TargetArch, OptLevel, TestPrefix,
                          Flags);
 
   if (BuildOnRead) {
     Ice::PNaClTranslator Translator(&Ctx, Flags);
     Translator.translate(IRFilename);
     return Translator.getErrorStatus();
   } else {
     // Parse the input LLVM IR file into a module.
@@ skipping 10 matching lines @@
     if (!Mod) {
       Err.print(argv[0], errs());
       return 1;
     }
 
     Ice::Converter Converter(Mod, &Ctx, Flags);
     Converter.convertToIce();
     return Converter.getErrorStatus();
   }
 }