Allow ability to name unnamed global addresses in Subzero.

tests_lit/reader_tests/unnamed.ll

Index: tests_lit/reader_tests/unnamed.ll
diff --git a/tests_lit/reader_tests/unnamed.ll b/tests_lit/reader_tests/unnamed.ll
new file mode 100644
index 0000000000000000000000000000000000000000..883445101a2916c009a85396ef0ea99eaa1cccba
--- /dev/null
+++ b/tests_lit/reader_tests/unnamed.ll
@@ -0,0 +1,45 @@
+; Tests that we name unnamed global addresses.
+
+; RUN: llvm-as < %s | pnacl-freeze \
+; RUN:              | %llvm2ice -notranslate -verbose=inst -build-on-read \
+; RUN:                -default-global-prefix=__g -allow-pnacl-reader-error-recovery \

[Jim Stichnoth, 2014/09/11 22:08:19]

80-char, here and line 10

+; RUN:              | FileCheck %s
+
+; RUN: llvm-as < %s | pnacl-freeze \
+; RUN:              | %llvm2ice -notranslate -verbose=inst -build-on-read \
+; RUN:                -default-global-prefix=h -allow-pnacl-reader-error-recovery \
+; RUN:        2>& 1 | FileCheck --check-prefix=BAD %s

[Jim Stichnoth, 2014/09/11 22:08:19]

Currently the warning message is going to llvm::outs() i.e. stdout not stderr,
so is there a reason for redirecting stderr?

[Karl, 2014/09/12 16:29:06]

Not anymore. Fixing.

+
+; TODO(kschimpf) Check global variable declarations, once generated.
+
+@0 = internal global [4 x i8] zeroinitializer, align 4
+@1 = internal constant [10 x i8] c"Some stuff", align 1
+
+define i32 @2(i32 %v) {
+  ret i32 %v
+}
+
+; CHECK:      define i32 @__g2(i32 %__0) {
+; CHECK-NEXT: __0:
+; CHECK-NEXT:   ret i32 %__0
+; CHECK-NEXT: }
+
+define void @hg() {
+  ret void
+}
+
+; BAD: Warning: Default global prefix 'h' conflicts with name 'hg'.
+
+; CHECK-NEXT: define void @hg() {
+; CHECK-NEXT: __0:
+; CHECK-NEXT:   ret void
+; CHECK-NEXT: }
+
+define void @3() {
+  ret void
+}
+
+; CHECK-NEXT: define void @__g3() {
+; CHECK-NEXT: __0:
+; CHECK-NEXT:   ret void
+; CHECK-NEXT: }