Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 567073004: Revert of Move the user agent styles sheets to blink_resources.grd (Part 3) (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-rendering, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Move the user agent styles sheets to blink_resources.grd (Part 3) (patchset #10 id:260001 of https://codereview.chromium.org/438843004/) Reason for revert: Speculative revert for breaking quite a few browser_tests and content_browsertests across multiple platforms: https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/26427 http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/9662 http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/5566 Original issue's description: > Move the user agent styles sheets to blink_resources.grd (Part 3) > > Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets. > This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. > > Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb. > > Part 1: https://codereview.chromium.org/436843004/ > Part 2: https://codereview.chromium.org/422023008 > Part 2 Unit Test support: https://codereview.chromium.org/456413002/ > > BUG=312586 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181917 TBR=eseidel@chromium.org,abarth@chromium.org,jochen@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -31 lines) Patch
M Source/core/BUILD.gn View 3 chunks +44 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +46 lines, -0 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 12 chunks +16 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jianli
Created Revert of Move the user agent styles sheets to blink_resources.grd (Part 3)
6 years, 3 months ago (2014-09-12 22:01:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567073004/1
6 years, 3 months ago (2014-09-12 22:02:10 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:02:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181938

Powered by Google App Engine
This is Rietveld 408576698