Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 566973002: Constify the rendering/ selection code (Closed)

Created:
6 years, 3 months ago by Julien - ping for review
Modified:
6 years, 3 months ago
Reviewers:
dsinclair
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Constify the rendering/ selection code Most of the code wasn't touching |this| or the renderers but they were not marked as const. This is needed for another change that I have. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -70 lines) Patch
M Source/core/rendering/EllipsisBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBR.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 10 chunks +15 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RootInlineBox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
lgtm
6 years, 3 months ago (2014-09-12 17:42:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566973002/1
6 years, 3 months ago (2014-09-12 18:29:45 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 20:46:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181929

Powered by Google App Engine
This is Rietveld 408576698