Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 566803002: Web Animations: Fix pseudo element keyframe style resolution crash (Closed)

Created:
6 years, 3 months ago by alancutter (OOO until 2018)
Modified:
6 years, 3 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), pdr., rjwright, rwlbuis, rune+blink, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Web Animations: Fix pseudo element keyframe style resolution crash Pseudo element keyframe animations were not being resolved with the correct StyleResolverState::element(). This bug is likely due to mismatched parameter names in CSSAnimations::calculateUpdate(). This patch corrects the Element passed to StyleResolverState when resolving keyframe animation styles and ensures the parameter names under CSSAnimations::calculateUpdate() and related helper functions are consistent with what gets passed in from StyleResolver::applyAnimatedProperties(). BUG=412979, 360457 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
A + LayoutTests/animations/pseudo-element-animation-with-marker-crash.html View 1 chunk +2 lines, -4 lines 0 comments Download
A + LayoutTests/animations/pseudo-element-animation-with-marker-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 9 chunks +20 lines, -21 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alancutter (OOO until 2018)
6 years, 3 months ago (2014-09-12 04:49:35 UTC) #2
dstockwell
+tim
6 years, 3 months ago (2014-09-15 23:55:43 UTC) #4
esprehn
lgtm
6 years, 3 months ago (2014-09-16 00:10:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566803002/1
6 years, 3 months ago (2014-09-16 00:14:36 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 06:20:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182031

Powered by Google App Engine
This is Rietveld 408576698