Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 566243004: Revert of PPAPI: Fix GetBrowserInterface race conditions (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of PPAPI: Fix GetBrowserInterface race conditions (patchset #6 id:100001 of https://codereview.chromium.org/568793002/) Reason for revert: Sorry to revert but I randomly noticed this to be causing a top crasher e.g. go/crash/75090c1e31f33cfd The reason is because the patch explicitly calls PluginGlobals::SetPluginProxyDelegate with NULL from PpapiThread::Shutdown but the pointer is used immediately inside the function. I guess it should be a simple fix. I was going to put up a fix which just reset the browser_sender_ to NULL in that case, but then I noticed there were cases where we call GetBrowserSender() and use it without checking whether it is NULL (e.g. https://code.google.com/p/chromium/codesearch#search/&q=%22PluginGlobals::Get()-%3EGetBrowserSender()-%3ESend%22&sq=package:chromium&type=cs) I felt it would be better to just revert for now, sorry :( Original issue's description: > PPAPI: Fix GetBrowserInterface race conditions > > BUG=413513 > > Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a > Cr-Commit-Position: refs/heads/master@{#294715} TBR=teravest@chromium.org,piman@chromium.org,dmichael@chromium.org NOTREECHECKS=true NOTRY=true BUG=413513 Committed: https://crrev.com/1d38f6f04696744d6b0e9972e5c95d25485da27e Cr-Commit-Position: refs/heads/master@{#294782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -72 lines) Patch
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/nacl_irt/plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/interface_list.h View 2 chunks +15 lines, -26 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 4 chunks +13 lines, -29 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
Created Revert of PPAPI: Fix GetBrowserInterface race conditions
6 years, 3 months ago (2014-09-15 03:45:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566243004/1
6 years, 3 months ago (2014-09-15 03:45:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d2abba86be4251e2c79ce58b280c4dd6034e0aea
6 years, 3 months ago (2014-09-15 03:48:58 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 03:59:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d38f6f04696744d6b0e9972e5c95d25485da27e
Cr-Commit-Position: refs/heads/master@{#294782}

Powered by Google App Engine
This is Rietveld 408576698