Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: ppapi/proxy/plugin_dispatcher.cc

Issue 566243004: Revert of PPAPI: Fix GetBrowserInterface race conditions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/interface_list.cc ('k') | ppapi/proxy/plugin_globals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_dispatcher.cc
diff --git a/ppapi/proxy/plugin_dispatcher.cc b/ppapi/proxy/plugin_dispatcher.cc
index ad3e7a066429e8197c10501680bfb414f68b5564..f6448d380c2a3b23aa4ef7f3fff37e82df81b998 100644
--- a/ppapi/proxy/plugin_dispatcher.cc
+++ b/ppapi/proxy/plugin_dispatcher.cc
@@ -108,8 +108,13 @@
// static
const void* PluginDispatcher::GetBrowserInterface(const char* interface_name) {
- // CAUTION: This function is called directly from the plugin, but we *don't*
- // lock the ProxyLock to avoid excessive locking from C++ wrappers.
+ if (!interface_name) {
+ DLOG(WARNING) << "|interface_name| is null. Did you forget to add "
+ "the |interface_name()| template function to the interface's C++ "
+ "wrapper?";
+ return NULL;
+ }
+
return InterfaceList::GetInstance()->GetInterfaceForPPB(interface_name);
}
« no previous file with comments | « ppapi/proxy/interface_list.cc ('k') | ppapi/proxy/plugin_globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698