Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: ppapi/proxy/interface_list.h

Issue 566243004: Revert of PPAPI: Fix GetBrowserInterface race conditions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/nacl_irt/plugin_main.cc ('k') | ppapi/proxy/interface_list.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_PROXY_INTERFACE_LIST_H_ 5 #ifndef PPAPI_PROXY_INTERFACE_LIST_H_
6 #define PPAPI_PROXY_INTERFACE_LIST_H_ 6 #define PPAPI_PROXY_INTERFACE_LIST_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/containers/scoped_ptr_hash_map.h"
13 #include "base/synchronization/lock.h"
14 #include "ppapi/proxy/interface_proxy.h" 12 #include "ppapi/proxy/interface_proxy.h"
15 #include "ppapi/proxy/ppapi_proxy_export.h" 13 #include "ppapi/proxy/ppapi_proxy_export.h"
16 #include "ppapi/shared_impl/ppapi_permissions.h" 14 #include "ppapi/shared_impl/ppapi_permissions.h"
17 15
18 namespace ppapi { 16 namespace ppapi {
19 namespace proxy { 17 namespace proxy {
20 18
21 class PPAPI_PROXY_EXPORT InterfaceList { 19 class PPAPI_PROXY_EXPORT InterfaceList {
22 public: 20 public:
23 InterfaceList(); 21 InterfaceList();
(...skipping 18 matching lines...) Expand all
42 InterfaceProxy::Factory GetFactoryForID(ApiID id) const; 40 InterfaceProxy::Factory GetFactoryForID(ApiID id) const;
43 41
44 // Returns the interface pointer for the given browser or plugin interface, 42 // Returns the interface pointer for the given browser or plugin interface,
45 // or NULL if it's not supported. 43 // or NULL if it's not supported.
46 const void* GetInterfaceForPPB(const std::string& name); 44 const void* GetInterfaceForPPB(const std::string& name);
47 const void* GetInterfaceForPPP(const std::string& name) const; 45 const void* GetInterfaceForPPP(const std::string& name) const;
48 46
49 private: 47 private:
50 friend class InterfaceListTest; 48 friend class InterfaceListTest;
51 49
52 class InterfaceInfo { 50 struct InterfaceInfo {
53 public: 51 InterfaceInfo()
52 : iface(NULL),
53 required_permission(PERMISSION_NONE),
54 interface_logged(false) {
55 }
54 InterfaceInfo(const void* in_interface, Permission in_perm) 56 InterfaceInfo(const void* in_interface, Permission in_perm)
55 : iface_(in_interface), 57 : iface(in_interface),
56 required_permission_(in_perm), 58 required_permission(in_perm),
57 sent_to_uma_(false) { 59 interface_logged(false) {
58 } 60 }
59 61
60 const void* iface() { return iface_; } 62 const void* iface;
61 63
62 // Permission required to return non-null for this interface. This will 64 // Permission required to return non-null for this interface. This will
63 // be checked with the value set via SetProcessGlobalPermissionBits when 65 // be checked with the value set via SetProcessGlobalPermissionBits when
64 // an interface is requested. 66 // an interface is requested.
65 Permission required_permission() { return required_permission_; }; 67 Permission required_permission;
66 68
67 // Call this any time the interface is requested. It will log a UMA count 69 // Interface usage is logged just once per-interface-per-plugin-process.
68 // only the first time. This is safe to call from any thread, regardless of 70 bool interface_logged;
69 // whether the proxy lock is held. 71 };
70 void LogWithUmaOnce(IPC::Sender* sender, const std::string& name);
71 private:
72 DISALLOW_COPY_AND_ASSIGN(InterfaceInfo);
73 72
74 const void* const iface_; 73 typedef std::map<std::string, InterfaceInfo> NameToInterfaceInfoMap;
75 const Permission required_permission_;
76
77 bool sent_to_uma_;
78 base::Lock sent_to_uma_lock_;
79 };
80 // Give friendship for HashInterfaceName.
81 friend class InterfaceInfo;
82
83 typedef base::ScopedPtrHashMap<std::string, InterfaceInfo>
84 NameToInterfaceInfoMap;
85 74
86 void AddProxy(ApiID id, InterfaceProxy::Factory factory); 75 void AddProxy(ApiID id, InterfaceProxy::Factory factory);
87 76
88 // Permissions is the type of permission required to access the corresponding 77 // Permissions is the type of permission required to access the corresponding
89 // interface. Currently this must be just one unique permission (rather than 78 // interface. Currently this must be just one unique permission (rather than
90 // a bitfield). 79 // a bitfield).
91 void AddPPB(const char* name, const void* iface, Permission permission); 80 void AddPPB(const char* name, const void* iface, Permission permission);
92 void AddPPP(const char* name, const void* iface); 81 void AddPPP(const char* name, const void* iface);
93 82
94 // Hash the interface name for UMA logging. 83 // Hash the interface name for UMA logging.
95 static int HashInterfaceName(const std::string& name); 84 static int HashInterfaceName(const std::string& name);
96 85
97 PpapiPermissions permissions_; 86 PpapiPermissions permissions_;
98 87
99 NameToInterfaceInfoMap name_to_browser_info_; 88 NameToInterfaceInfoMap name_to_browser_info_;
100 NameToInterfaceInfoMap name_to_plugin_info_; 89 NameToInterfaceInfoMap name_to_plugin_info_;
101 90
102 InterfaceProxy::Factory id_to_factory_[API_ID_COUNT]; 91 InterfaceProxy::Factory id_to_factory_[API_ID_COUNT];
103 92
104 DISALLOW_COPY_AND_ASSIGN(InterfaceList); 93 DISALLOW_COPY_AND_ASSIGN(InterfaceList);
105 }; 94 };
106 95
107 } // namespace proxy 96 } // namespace proxy
108 } // namespace ppapi 97 } // namespace ppapi
109 98
110 #endif // PPAPI_PROXY_INTERFACE_LIST_H_ 99 #endif // PPAPI_PROXY_INTERFACE_LIST_H_
111 100
OLDNEW
« no previous file with comments | « ppapi/nacl_irt/plugin_main.cc ('k') | ppapi/proxy/interface_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698