Move TranslateHelper to the translate component.

Move TranslateHelper to the translate component.

This CL moves TranslateHelper to the translate component.

A couple dependencies had to be injected, through the constructor:
- extensions (group and scheme)
- isolated world id

BUG=335087
TBR=jochen

Committed: https://crrev.com/f1da1804fb44d2c36fe10d11808c1cfc0c369fcf
Cr-Commit-Position: refs/heads/master@{#295276}

[droger, 2014-09-11 13:39:28]

droger@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Takashi Toyoshima, 2014-09-16 06:51:56]

Just one question on this CL.

https://codereview.chromium.org/564793003/diff/60001/components/translate/con...
File components/translate/content/renderer/DEPS (right):

https://codereview.chromium.org/564793003/diff/60001/components/translate/con...
components/translate/content/renderer/DEPS:5: "+v8",
Is there any reason of that adding WebKit and v8 is ok, but adding extensions is
bad here?
I guess we do not want to have a dependency to a module that does not exit on
mobile platforms, and extensions is the case. But, I do not think WebKit and v8
is available on iOS. So is there any difference between them and extensions?

[droger, 2014-09-16 08:01:58]

https://codereview.chromium.org/564793003/diff/60001/components/translate/con...
File components/translate/content/renderer/DEPS (right):

https://codereview.chromium.org/564793003/diff/60001/components/translate/con...
components/translate/content/renderer/DEPS:5: "+v8",
On 2014/09/16 06:51:55, Takashi Toyoshima (chromium) wrote:
> Is there any reason of that adding WebKit and v8 is ok, but adding extensions
is
> bad here?
> I guess we do not want to have a dependency to a module that does not exit on
> mobile platforms, and extensions is the case. But, I do not think WebKit and
v8
> is available on iOS. So is there any difference between them and extensions?

As I understand, the dependencies go like this:

extensions
component
v8

That is, components can depends on v8, and extensions depend on components.

I'm saying this because I had gyp errors (circular dependencies) when I tried to
have the component depend on extensions.
We can also see in extension/DEPS and extensions/extensions.gyp that extensions
depend on several components.

That said, I am really unfamiliar with extensions, so if you are sure that it is
ok for a component to depend on extensions, then I can try again and see if I
can resolve the circular dependencies.

[Takashi Toyoshima, 2014-09-16 11:46:34]

I had this question because I noticed that component/renderer_context_menu/DEPS
has dependencies to extensions/browser and extensions/common. I'm also not
familiar with extensions dependency, but if we can depends on extensions, that
makes things simpler. I do not have a strong opinion on that, but if you can try
it again, it's great.

[droger, 2014-09-16 13:38:30]

On 2014/09/16 11:46:34, Takashi Toyoshima (chromium) wrote:
> I had this question because I noticed that
component/renderer_context_menu/DEPS
> has dependencies to extensions/browser and extensions/common. I'm also not
> familiar with extensions dependency, but if we can depends on extensions, that
> makes things simpler. I do not have a strong opinion on that, but if you can
try
> it again, it's great.

I checked with a //components owner (blundell) and he confirmed that extensions
are on top of components, and that the dependency you are pointing out is a bug.

Also note that the dependency you found is only a DEPS file, but there is no
dependency in gyp. A dependency in gyp would be impossible and would not build.

[Takashi Toyoshima, 2014-09-16 13:44:52]

thank you for checking it!
So, this change LGTM.

[droger, 2014-09-16 15:05:49]

droger@chromium.org changed reviewers:
+ jochen@chromium.org

[droger, 2014-09-16 15:06:50]

TBR= jochen for
- new dependencies of components/translate/content/renderer/DEPS
- trivial change in chrome/renderer/chrome_render_view_observer

[droger, 2014-09-16 15:08:27]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-09-16 15:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564793003/60001

[commit-bot: I haz the power, 2014-09-16 15:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 15:12:39]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[droger, 2014-09-17 08:49:42]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-09-17 08:49:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564793003/80001

[commit-bot: I haz the power, 2014-09-17 08:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 08:53:44]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57038)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[droger, 2014-09-17 11:06:51]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-09-17 11:07:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564793003/100001

[commit-bot: I haz the power, 2014-09-17 13:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 13:07:33]

Exceeded time limit waiting for builds to trigger.

[droger, 2014-09-17 14:23:28]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-09-17 14:23:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564793003/100001

[commit-bot: I haz the power, 2014-09-17 14:54:12]

Committed patchset #6 (id:100001) as 20067cbc76af3d5554c8f7a105ada4895695e7a2

[commit-bot: I haz the power, 2014-09-17 14:54:45]

Patchset 6 (id:??) landed as
https://crrev.com/f1da1804fb44d2c36fe10d11808c1cfc0c369fcf
Cr-Commit-Position: refs/heads/master@{#295276}