Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Unified Diff: chrome/renderer/translate/translate_helper_browsertest.cc

Issue 564793003: Move TranslateHelper to the translate component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@translateBrowserIPC
Patch Set: rebase AGAIN Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/translate/translate_helper.cc ('k') | components/translate.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/translate/translate_helper_browsertest.cc
diff --git a/chrome/renderer/translate/translate_helper_browsertest.cc b/chrome/renderer/translate/translate_helper_browsertest.cc
index 1d462f825c5f9f8a3f2538b3c4a7e86ec4092989..c87585755a6ac77234aa3b2eca9519133407ef80 100644
--- a/chrome/renderer/translate/translate_helper_browsertest.cc
+++ b/chrome/renderer/translate/translate_helper_browsertest.cc
@@ -3,11 +3,14 @@
// found in the LICENSE file.
#include "base/time/time.h"
-#include "chrome/renderer/translate/translate_helper.h"
+#include "chrome/renderer/isolated_world_ids.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "components/translate/content/common/translate_messages.h"
+#include "components/translate/content/renderer/translate_helper.h"
#include "components/translate/core/common/translate_constants.h"
#include "content/public/renderer/render_view.h"
+#include "extensions/common/constants.h"
+#include "extensions/renderer/extension_groups.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
@@ -16,11 +19,14 @@ using testing::AtLeast;
using testing::Return;
using testing::_;
-class TestTranslateHelper : public TranslateHelper {
+class TestTranslateHelper : public translate::TranslateHelper {
public:
explicit TestTranslateHelper(content::RenderView* render_view)
- : TranslateHelper(render_view) {
- }
+ : translate::TranslateHelper(
+ render_view,
+ chrome::ISOLATED_WORLD_ID_TRANSLATE,
+ extensions::EXTENSION_GROUP_INTERNAL_TRANSLATE_SCRIPTS,
+ extensions::kExtensionScheme) {}
virtual base::TimeDelta AdjustDelay(int delayInMs) OVERRIDE {
// Just returns base::TimeDelta() which has initial value 0.
« no previous file with comments | « chrome/renderer/translate/translate_helper.cc ('k') | components/translate.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698