components/translate/content/renderer/DEPS - Issue 564793003: Move TranslateHelper to the translate component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/translate/content/renderer/DEPS

Issue 564793003: Move TranslateHelper to the translate component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@translateBrowserIPC

Patch Set: fix gn Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public/renderer",	2 "+content/public/renderer",

3 "+third_party/cld_2",	3 "+third_party/cld_2",

	4 "+third_party/WebKit/public/web",

	5 "+v8",
	Takashi Toyoshima 2014/09/16 06:51:55 Is there any reason of that adding WebKit and v8 i Is there any reason of that adding WebKit and v8 is ok, but adding extensions is bad here? I guess we do not want to have a dependency to a module that does not exit on mobile platforms, and extensions is the case. But, I do not think WebKit and v8 is available on iOS. So is there any difference between them and extensions? droger 2014/09/16 08:01:58 As I understand, the dependencies go like this: e Show quoted text On 2014/09/16 06:51:55, Takashi Toyoshima (chromium) wrote: > Is there any reason of that adding WebKit and v8 is ok, but adding extensions is > bad here? > I guess we do not want to have a dependency to a module that does not exit on > mobile platforms, and extensions is the case. But, I do not think WebKit and v8 > is available on iOS. So is there any difference between them and extensions? As I understand, the dependencies go like this: extensions component v8 That is, components can depends on v8, and extensions depend on components. I'm saying this because I had gyp errors (circular dependencies) when I tried to have the component depend on extensions. We can also see in extension/DEPS and extensions/extensions.gyp that extensions depend on several components. That said, I am really unfamiliar with extensions, so if you are sure that it is ok for a component to depend on extensions, then I can try again and see if I can resolve the circular dependencies.
4 ]	6 ]

OLD	NEW

« no previous file with comments | « components/translate/content/renderer/BUILD.gn ('k') | components/translate/content/renderer/translate_helper.h » ('j') | no next file with comments »