Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file*

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file*

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610
Committed: https://crrev.com/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727
Cr-Commit-Position: refs/heads/master@{#294309}

[dcheng, 2014-09-10 21:19:10]

dcheng@chromium.org changed reviewers:
+ mtomasz@chromium.org

[dcheng, 2014-09-10 21:19:10]

Unfortunately, we can't make scoped_refptr testable until the conversion
operator has been removed. While it would be possible to disable the conversion
operator and make it testable in the same patch, the automated tool tries to
skip rewriting code where manual cleanups would be useful. This includes things
like:

// What if ReturnsScopedRefPtr() creates a new object internally?
if (ReturnsScopedRefPtr())

Foo* Bar() {
  const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
  return f;  // Does the return type need to be rewritten? Or is .get() safe?
}

Doing this in one patch would make catching some of these instances (in
particular, a boolean test on a temporary scoped_refptr) more difficult. As a
result, the work is being split into several steps:
Step 1: Rewrite all implicit conversions to be explicit (or rewrite the receiver
type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
Step 2: Once a platform compiles cleanly without the conversion operator, #ifdef
the conversion operator out.
Step 3: Make scoped_refptr testable on that platform.
Step 4: Remove unnecessary calls to .get().

[mtomasz, 2014-09-11 01:59:04]

https://codereview.chromium.org/564503002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_manager/file_browser_handlers.cc (right):

https://codereview.chromium.org/564503002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/file_browser_handlers.cc:408: const
Extension* extension,
The |extension| argument seems unused, and it's confusing. Could you remove
please since you're here?

[dcheng, 2014-09-11 02:04:07]

https://codereview.chromium.org/564503002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_manager/file_browser_handlers.cc (right):

https://codereview.chromium.org/564503002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/file_browser_handlers.cc:408: const
Extension* extension,
On 2014/09/11 01:59:04, mtomasz wrote:
> The |extension| argument seems unused, and it's confusing. Could you remove
> please since you're here?

I'm happy to do this cleanup, but would you mind if I removed it in a followup
CL? This was split off a large master diff locally, and deferring this to a
separate patch will make merges a bit easier for me.

[mtomasz, 2014-09-11 02:26:28]

On 2014/09/11 02:04:07, dcheng (OOO) wrote:
>
https://codereview.chromium.org/564503002/diff/1/chrome/browser/chromeos/file...
> File chrome/browser/chromeos/file_manager/file_browser_handlers.cc (right):
> 
>
https://codereview.chromium.org/564503002/diff/1/chrome/browser/chromeos/file...
> chrome/browser/chromeos/file_manager/file_browser_handlers.cc:408: const
> Extension* extension,
> On 2014/09/11 01:59:04, mtomasz wrote:
> > The |extension| argument seems unused, and it's confusing. Could you remove
> > please since you're here?
> 
> I'm happy to do this cleanup, but would you mind if I removed it in a followup
> CL? This was split off a large master diff locally, and deferring this to a
> separate patch will make merges a bit easier for me.

SGTM + LGTM + Thanks.

[dcheng, 2014-09-11 02:36:36]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-09-11 02:37:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564503002/1

[commit-bot: I haz the power, 2014-09-11 03:10:31]

Committed patchset #1 (id:1) as 1df730832924303b28d7333e24406fec57127a5c

[commit-bot: I haz the power, 2014-09-11 03:14:14]

Patchset 1 (id:??) landed as
https://crrev.com/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727
Cr-Commit-Position: refs/heads/master@{#294309}