chrome/browser/chromeos/file_manager/snapshot_manager.cc - Issue 564503002: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/snapshot_manager.cc

Issue 564503002: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/file_manager/file_browser_handlers.cc ('K') | « chrome/browser/chromeos/file_manager/file_browser_handlers.cc ('k') | chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/snapshot_manager.cc

diff --git a/chrome/browser/chromeos/file_manager/snapshot_manager.cc b/chrome/browser/chromeos/file_manager/snapshot_manager.cc

index 57fd74477408fdcabdcc3f75854cbcdec407a30f..edecdd140bfec004f2fa4fb55a5d481010be9c23 100644

--- a/chrome/browser/chromeos/file_manager/snapshot_manager.cc

+++ b/chrome/browser/chromeos/file_manager/snapshot_manager.cc

@@ -128,7 +128,7 @@ void SnapshotManager::CreateManagedSnapshot(

const LocalPathCallback& callback) {

scoped_refptr<storage::FileSystemContext> context(

util::GetFileSystemContextForExtensionId(profile_, kFileManagerAppId));

- DCHECK(context);

+ DCHECK(context.get());

GURL url;

if (!util::ConvertAbsoluteFilePathToFileSystemUrl(

@@ -151,7 +151,7 @@ void SnapshotManager::CreateManagedSnapshotAfterSpaceComputed(

int64 needed_space) {

scoped_refptr<storage::FileSystemContext> context(

util::GetFileSystemContextForExtensionId(profile_, kFileManagerAppId));

- DCHECK(context);

+ DCHECK(context.get());

if (needed_space < 0) {

callback.Run(base::FilePath());