chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc - Issue 564503002: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc

Issue 564503002: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/file_manager/file_browser_handlers.cc ('K') | « chrome/browser/chromeos/file_manager/snapshot_manager.cc ('k') | chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc

diff --git a/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc b/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc

index 831d65f3b25c3de706ca1e1e0079738bf050c82d..a41cd18964a5a99813135899d9e37aa0b8216aed 100644

--- a/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc

+++ b/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc

@@ -84,8 +84,8 @@ void BufferingFileStreamReader::Preload(

// when reading just small chunks, instead of the entire file.

const int preload_bytes = buffer_size_;

- const int result =

- file_stream_reader_->Read(preloading_buffer_, preload_bytes, callback);

+ const int result = file_stream_reader_->Read(

+ preloading_buffer_.get(), preload_bytes, callback);

DCHECK_EQ(result, net::ERR_IO_PENDING);

}