Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt

Issue 564453002: Blink GC plugin: Check polymorphic requirements on all GC-derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix test error from previous CL Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt
diff --git a/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt b/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt
index 0c1967c015ef2f06889d38ad3ce165c0e9c3f8e9..fb466967a3350a8292e6e576f31dfdeda53e330e 100644
--- a/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt
+++ b/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.txt
@@ -1,8 +1,11 @@
In file included from virtual_and_trace_after_dispatch.cpp:5:
+./virtual_and_trace_after_dispatch.h:12:1: warning: [blink-gc] Left-most base class 'A' of derived class 'B' must be polymorphic.
+class A : public GarbageCollected<A> {
+^
./virtual_and_trace_after_dispatch.h:23:1: warning: [blink-gc] Class 'B' contains or inherits virtual methods but implements manual dispatching.
class B : public A {
^
./virtual_and_trace_after_dispatch.h:14:5: note: [blink-gc] Manual dispatch 'trace' declared here:
void trace(Visitor*);
^
-1 warning generated.
+2 warnings generated.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698