Issue 5640001: Polish the about:conflicts page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5640001: Polish the about:conflicts page.... (Closed)

Created:
10 years ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Polish the about:conflicts page. Address review comments from Nico and add a separating line as requested by Glen. BUG=51105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68346

Patch Set 1 #

Total comments: 4

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -18 lines)			Patch
	M	chrome/browser/resources/about_conflicts.html	View		2 chunks	+38 lines, -18 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

the datacell stuff LG if you want to submit this in a separate CL http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_conflicts.html ...

10 years ago (2010-12-03 18:51:01 UTC) #2

Finnur

10 years ago (2010-12-06 11:35:05 UTC) #3

http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_...
File chrome/browser/resources/about_conflicts.html (right):

http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_...
chrome/browser/resources/about_conflicts.html:155: }
I tried many variations of this and couldn't get it to work...

On 2010/12/03 18:51:01, Nico wrote:
> does
> 
> .extra-info-block > * { display:block; }
> 
> work instead of this as well?

http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_...
chrome/browser/resources/about_conflicts.html:277:
i18n-content="helpCenterLink">HELP_CENTER</span></a>
Nope, I don't need the span. Removed. Thanks.

On 2010/12/03 18:51:01, Nico wrote:
> do you need the span in the a, or can you put the i18n-content in the a
> directly?

Expand Messages | Collapse Messages