Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: chrome/browser/resources/about_conflicts.html

Issue 5640001: Polish the about:conflicts page.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection;"> 2 <html i18n-values="dir:textdirection;">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <style> 5 <style>
6 body { 6 body {
7 margin: 10px; 7 margin: 10px;
8 min-width: 47em; 8 min-width: 47em;
9 } 9 }
10 10
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 } 136 }
137 137
138 .nowrap { 138 .nowrap {
139 white-space: nowrap; 139 white-space: nowrap;
140 } 140 }
141 141
142 .extra-info-text { 142 .extra-info-text {
143 margin-top: -1em; 143 margin-top: -1em;
144 margin-bottom: 1em; 144 margin-bottom: 1em;
145 } 145 }
146
147 .clearing {
148 clear: left;
149 float: left;
150 }
151
152 html[dir=rtl] .clearing {
153 clear: right;
154 float: right;
155 }
Nico 2010/12/03 18:51:01 does .extra-info-block > * { display:block; } wo
Finnur 2010/12/06 11:35:05 I tried many variations of this and couldn't get i
156
157 .datacell {
158 border-bottom: 1px solid #aaa;
159 }
146 </style> 160 </style>
147 <script> 161 <script>
148 162
149 /** 163 /**
150 * This variable structure is here to document the structure that the template 164 * This variable structure is here to document the structure that the template
151 * expects to correctly populate the page. 165 * expects to correctly populate the page.
152 */ 166 */
153 var moduleListDataFormat = { 167 var moduleListDataFormat = {
154 'moduleList': [ 168 'moduleList': [
155 { 169 {
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 jsdisplay="moduleList.length === 0"> 252 jsdisplay="moduleList.length === 0">
239 <div i18n-content="modulesNoneLoaded">NO_MODULES_ARE_AVAILABLE</div> 253 <div i18n-content="modulesNoneLoaded">NO_MODULES_ARE_AVAILABLE</div>
240 </div> 254 </div>
241 255
242 <div jsdisplay="moduleList.length &gt; 0"> 256 <div jsdisplay="moduleList.length &gt; 0">
243 <table width="100%" cellpadding="0" cellspacing="0"> 257 <table width="100%" cellpadding="0" cellspacing="0">
244 <tr class="module-loaded"> 258 <tr class="module-loaded">
245 <td valign="top"> 259 <td valign="top">
246 <table cellpadding="2" cellspacing="0" border="0"> 260 <table cellpadding="2" cellspacing="0" border="0">
247 <tr jsselect="moduleList"> 261 <tr jsselect="moduleList">
248 <td valign="top"> 262 <td valign="top" class="datacell">
249 <span dir="ltr" 263 <span dir="ltr"
250 jsvalues=".innerHTML:description" class="nowrap"></span> 264 jsvalues=".innerHTML:description"
265 class="clearing nowrap"></span>
251 <div jsdisplay="status == 2 || status == 3" 266 <div jsdisplay="status == 2 || status == 3"
252 class="extra-info-text"><br> 267 class="extra-info-text">
253 <span jsdisplay="status == 2" 268 <span class="clearing">
254 i18n-content="moduleSuspectedBad" 269 <span jsdisplay="status == 2"
255 class="suspected-bad">SUSPECTED_BAD</span> 270 i18n-content="moduleSuspectedBad"
256 <span jsdisplay="status == 3" 271 class="suspected-bad">SUSPECTED_BAD</span>
257 i18n-content="moduleConfirmedBad" 272 <span jsdisplay="status == 3"
258 class="confirmed-bad">CONFIRMED_BAD</span> 273 i18n-content="moduleConfirmedBad"
259 <a jsdisplay="help_url.length &gt; 0" 274 class="confirmed-bad">CONFIRMED_BAD</span>
260 jsvalues=".href:help_url"><span 275 <a jsdisplay="help_url.length &gt; 0"
261 i18n-content="helpCenterLink">HELP_CENTER</span></a> 276 jsvalues=".href:help_url"><span
262 <span jsdisplay="possibleResolution.length &gt; 0"><br> 277 i18n-content="helpCenterLink">HELP_CENTER</span></a>
Nico 2010/12/03 18:51:01 do you need the span in the a, or can you put the
Finnur 2010/12/06 11:35:05 Nope, I don't need the span. Removed. Thanks. On
263 <span jscontent="possibleResolution" 278 </span>
279 <span jsdisplay="possibleResolution.length &gt; 0">
280 <span jscontent="possibleResolution" class="clearing"
264 >POSSIBLE_RESOLUTION</span> 281 >POSSIBLE_RESOLUTION</span>
265 </span> 282 </span>
266 </div> 283 </div>
267 </td> 284 </td>
268 <td valign="top"><span dir="ltr" jscontent="digital_signer" 285 <td valign="top" class="datacell"><span dir="ltr"
286 jscontent="digital_signer"
269 class="nowrap">SIGNER</span></td> 287 class="nowrap">SIGNER</span></td>
270 <td valign="top"><span dir="ltr" jscontent="version" 288 <td valign="top" class="datacell"><span dir="ltr"
271 class="nowrap">VERSION</span></td> 289 jscontent="version"
272 <td valign="top"> 290 class="nowrap">VERSION</span
291 ></td>
292 <td valign="top" class="datacell">
273 <span class="nowrap"> 293 <span class="nowrap">
274 <span dir="ltr" jscontent="location">LOCATION</span><strong 294 <span dir="ltr" jscontent="location">LOCATION</span><strong
275 ><span dir="ltr" jscontent="name">NAME</span></strong> 295 ><span dir="ltr" jscontent="name">NAME</span></strong>
276 <span dir="ltr" 296 <span dir="ltr"
277 jsdisplay="type_description.length &gt; 0" 297 jsdisplay="type_description.length &gt; 0"
278 >(<span dir="ltr" 298 >(<span dir="ltr"
279 jscontent="type_description">MODULE_TYPE</span 299 jscontent="type_description">MODULE_TYPE</span
280 >)</span> 300 >)</span>
281 </span> 301 </span>
282 </td> 302 </td>
283 </tr> 303 </tr>
284 </table> 304 </table>
285 </td> 305 </td>
286 </tr> 306 </tr>
287 </table> 307 </table>
288 </div> 308 </div>
289 </div> 309 </div>
290 </div> 310 </div>
291 </div> 311 </div>
292 </body> 312 </body>
293 </html> 313 </html>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698