Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 5640001: Polish the about:conflicts page.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
5 years, 7 months ago by Finnur (OOO summer vacation)
5 years, 1 month ago
chromium-reviews, arv (Not doing code reviews),


Polish the about:conflicts page. Address review comments from Nico and add a separating line as requested by Glen. BUG=51105 TEST=None Committed:

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M chrome/browser/resources/about_conflicts.html View 2 chunks +38 lines, -18 lines 4 comments Download
Commit queue not available (can’t edit this change).


Total messages: 3 (0 generated)
Finnur (OOO summer vacation)
5 years, 7 months ago (2010-12-03 12:48:10 UTC) #1
Nico (ooo until Aug 1)
the datacell stuff LG if you want to submit this in a separate CL ...
5 years, 7 months ago (2010-12-03 18:51:01 UTC) #2
Finnur (OOO summer vacation)
5 years, 7 months ago (2010-12-06 11:35:05 UTC) #3
File chrome/browser/resources/about_conflicts.html (right):
chrome/browser/resources/about_conflicts.html:155: }
I tried many variations of this and couldn't get it to work...

On 2010/12/03 18:51:01, Nico wrote:
> does
> .extra-info-block > * { display:block; }
> work instead of this as well?
Nope, I don't need the span. Removed. Thanks.

On 2010/12/03 18:51:01, Nico wrote:
> do you need the span in the a, or can you put the i18n-content in the a
> directly?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 18aec74