Chromium Code Reviews
Help | Chromium Project | Sign in
(57)

Issue 5640001: Polish the about:conflicts page.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Finnur
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, arv, ben+cc_chromium.org
Visibility:
Public.

Description

Polish the about:conflicts page. Address review comments from Nico and add a separating line as requested by Glen. BUG=51105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68346

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M chrome/browser/resources/about_conflicts.html View 2 chunks +38 lines, -18 lines 4 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Finnur
4 years, 5 months ago (2010-12-03 12:48:10 UTC) #1
Nico
the datacell stuff LG if you want to submit this in a separate CL http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_conflicts.html ...
4 years, 5 months ago (2010-12-03 18:51:01 UTC) #2
Finnur
4 years, 5 months ago (2010-12-06 11:35:05 UTC) #3
http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_...
File chrome/browser/resources/about_conflicts.html (right):

http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_...
chrome/browser/resources/about_conflicts.html:155: }
I tried many variations of this and couldn't get it to work...

On 2010/12/03 18:51:01, Nico wrote:
> does
> 
> .extra-info-block > * { display:block; }
> 
> work instead of this as well?

http://codereview.chromium.org/5640001/diff/1/chrome/browser/resources/about_...
chrome/browser/resources/about_conflicts.html:277:
i18n-content="helpCenterLink">HELP_CENTER</span></a>
Nope, I don't need the span. Removed. Thanks.

On 2010/12/03 18:51:01, Nico wrote:
> do you need the span in the a, or can you put the i18n-content in the a
> directly?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld aa3c3d4