Un-inline requestPaintingResource in RenderSVGResource.cpp

Un-inline requestPaintingResource in RenderSVGResource.cpp

This method is large, and the gain that propagating the constant mode from
its caller is relatively small. Make {fill,stroke}PaintingResource default
inline instead, and un-inline requestPaintingResource and move it into the
class.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181906

[fs, 2014-09-12 10:48:56]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[f(malita), 2014-09-12 14:17:52]

lgtm

https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGResource.h (right):

https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGResource.h:82: static RenderSVGResource*
strokePaintingResource(RenderObject* object, const RenderStyle* style, bool&
hasFallback)
These wrappers seem to add little value. We should just drop them at some point
and have clients use requestPaintingResource + mode enum directly.

[fs, 2014-09-12 14:30:30]

https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGResource.h (right):

https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGResource.h:82: static RenderSVGResource*
strokePaintingResource(RenderObject* object, const RenderStyle* style, bool&
hasFallback)
On 2014/09/12 14:17:52, Florin Malita wrote:
> These wrappers seem to add little value. We should just drop them at some
point
> and have clients use requestPaintingResource + mode enum directly.

Yeah, I've been thing along the same lines. I'll add it to my list.

[fs, 2014-09-12 14:30:34]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-09-12 14:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563973003/1

[commit-bot: I haz the power, 2014-09-12 14:36:59]

Committed patchset #1 (id:1) as 181906