Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 563973003: Un-inline requestPaintingResource in RenderSVGResource.cpp (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Un-inline requestPaintingResource in RenderSVGResource.cpp This method is large, and the gain that propagating the constant mode from its caller is relatively small. Make {fill,stroke}PaintingResource default inline instead, and un-inline requestPaintingResource and move it into the class. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181906

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +11 lines, -2 lines 2 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
6 years, 3 months ago (2014-09-12 12:04:06 UTC) #2
f(malita)
lgtm https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/RenderSVGResource.h File Source/core/rendering/svg/RenderSVGResource.h (right): https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/RenderSVGResource.h#newcode82 Source/core/rendering/svg/RenderSVGResource.h:82: static RenderSVGResource* strokePaintingResource(RenderObject* object, const RenderStyle* style, bool& ...
6 years, 3 months ago (2014-09-12 14:17:52 UTC) #3
fs
https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/RenderSVGResource.h File Source/core/rendering/svg/RenderSVGResource.h (right): https://codereview.chromium.org/563973003/diff/1/Source/core/rendering/svg/RenderSVGResource.h#newcode82 Source/core/rendering/svg/RenderSVGResource.h:82: static RenderSVGResource* strokePaintingResource(RenderObject* object, const RenderStyle* style, bool& hasFallback) ...
6 years, 3 months ago (2014-09-12 14:30:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563973003/1
6 years, 3 months ago (2014-09-12 14:31:35 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 14:36:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181906

Powered by Google App Engine
This is Rietveld 408576698