Un-inline requestPaintingResource in RenderSVGResource.cpp

Source/core/rendering/svg/RenderSVGResource.h

Index: Source/core/rendering/svg/RenderSVGResource.h
diff --git a/Source/core/rendering/svg/RenderSVGResource.h b/Source/core/rendering/svg/RenderSVGResource.h
index 31c6c51235065d20243d5bf9195de406ffcaae9d..9d8a3432f52ccaf7321b9879f7153591c6e076d7 100644
--- a/Source/core/rendering/svg/RenderSVGResource.h
+++ b/Source/core/rendering/svg/RenderSVGResource.h
@@ -75,11 +75,20 @@ public:
 
     // Helper utilities used in the render tree to access resources used for painting shapes/text (gradients & patterns & solid colors only)
     // If hasFallback gets set to true, the sharedSolidPaintingResource is set to a fallback color.
-    static RenderSVGResource* fillPaintingResource(RenderObject*, const RenderStyle*, bool& hasFallback);
-    static RenderSVGResource* strokePaintingResource(RenderObject*, const RenderStyle*, bool& hasFallback);
+    static RenderSVGResource* fillPaintingResource(RenderObject* object, const RenderStyle* style, bool& hasFallback)
+    {
+        return requestPaintingResource(ApplyToFillMode, object, style, hasFallback);
+    }
+    static RenderSVGResource* strokePaintingResource(RenderObject* object, const RenderStyle* style, bool& hasFallback)

[f(malita), 2014/09/12 14:17:52]

These wrappers seem to add little value. We should just drop them at some point
and have clients use requestPaintingResource + mode enum directly.

[fs, 2014/09/12 14:30:29]

Yeah, I've been thing along the same lines. I'll add it to my list.

+    {
+        return requestPaintingResource(ApplyToStrokeMode, object, style, hasFallback);
+    }
     static RenderSVGResourceSolidColor* sharedSolidPaintingResource();
 
     static void markForLayoutAndParentResourceInvalidation(RenderObject*, bool needsLayout = true);
+
+private:
+    static RenderSVGResource* requestPaintingResource(RenderSVGResourceMode, RenderObject*, const RenderStyle*, bool& hasFallback);
 };
 
 #define DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS(thisType, typeName) \